Fix predicate for updating global flag - #26
Merged
Conversation
rsiyer-intel
approved these changes
Mar 31, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates a low-level scaling guideline to use a sensible predicate when setting a shared “global flag”, avoiding unnecessary writes to a contended cache line.
Changes:
- Fixes the pseudocode example to only write
truewhen the flag is currentlyfalse.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
harp-intel
approved these changes
Mar 31, 2026
harp-intel
left a comment
harp-intel
left a comment
Contributor
There was a problem hiding this comment.
Good catch. Thank you.
Contributor
|
Yes make sense. But the second change to the malloc line seems to be spurious? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current psuedo code writes true only if the flag is already true which is not sensible