You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 11, 2017. It is now read-only.
@insin this is a question as much as a PR. the css loading is specified in a way I've never seen. why the combine loaders, then the + '!'. I couldn't seem to get less loading to work in the same way. Also, are the require.resolve statements necessary?
Everything which is configured with require.resolve is to save us having to worry about which working directory heatpack is running in, as the config points at absolute paths to heatpack's own dependencies.
The manual tagging on of the ! for autoprefixer is because autoprefixer can't deal with an empty query object - see jsdf/webpack-combine-loaders#1. I ended up rolling my own version of this for nwb, where it's done this way to allow the user to tweak the configuration of every loader, so that might have been some cross-pollination :)
@pwmckenna It'd also be nice to include sass/scss support, since those are fairly commonly used too. I don't mind making another PR based on this one, but it seems like @insin might've forgotten about this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
builds off of the incomplete babel6 pr.
@insin this is a question as much as a PR. the css loading is specified in a way I've never seen. why the combine loaders, then the
+ '!'. I couldn't seem to get less loading to work in the same way. Also, are therequire.resolvestatements necessary?