Skip to content
This repository was archived by the owner on Nov 11, 2017. It is now read-only.

Less#21

Open
pwmckenna wants to merge 8 commits into
insin:masterfrom
pwmckenna:less
Open

Less#21
pwmckenna wants to merge 8 commits into
insin:masterfrom
pwmckenna:less

Conversation

@pwmckenna

Copy link
Copy Markdown
Contributor

builds off of the incomplete babel6 pr.

@insin this is a question as much as a PR. the css loading is specified in a way I've never seen. why the combine loaders, then the + '!'. I couldn't seem to get less loading to work in the same way. Also, are the require.resolve statements necessary?

@insin

insin commented Dec 11, 2015

Copy link
Copy Markdown
Owner

Everything which is configured with require.resolve is to save us having to worry about which working directory heatpack is running in, as the config points at absolute paths to heatpack's own dependencies.

The manual tagging on of the ! for autoprefixer is because autoprefixer can't deal with an empty query object - see jsdf/webpack-combine-loaders#1. I ended up rolling my own version of this for nwb, where it's done this way to allow the user to tweak the configuration of every loader, so that might have been some cross-pollination :)

@pwmckenna

Copy link
Copy Markdown
Contributor Author

@insin this should be ready now...any idea how many types of files you'd like to support?

@sohkai

sohkai commented Feb 10, 2016

Copy link
Copy Markdown

@pwmckenna It'd also be nice to include sass/scss support, since those are fairly commonly used too. I don't mind making another PR based on this one, but it seems like @insin might've forgotten about this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants