Introduce teal_data class - #925
Conversation
following new teal_data class
reverting breaking changes and supporting teal_data
| if (is.null(raw_data())) { | ||
| return(NULL) | ||
| } | ||
| datasets_reactive <- eventReactive(raw_data(), ignoreNULL = TRUE, { |
There was a problem hiding this comment.
Any reason for explicitly setting ignoreNULL to default?
There was a problem hiding this comment.
No, I should remove it because eventReactive has ignoreNULL = TRUE by default, which is exactly what we need here.
Code Coverage SummaryDiff against mainResults for commit: 2d688f2 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
| # raw_data contains TealDataAbstract, i.e. R6 object and container for data | ||
| # reactive to get data through delayed loading | ||
| # we must leave it inside the server because of callModule which needs to pick up the right session |
fix 1 after merge
fix 2 after merge
teal_data instead of new_teal_data
remove generic get_join_keys (duplicated with teal.data)
|
that's a great simplification to the data specification where one does no longer need to use |
fix pkgdown
There was a problem hiding this comment.
should init accept empty teal_data?
Currently does but then error is raised by init_filtered_data downstream.
Followup to: