Skip to content

Introduce teal_data class - #925

Merged
gogonzo merged 29 commits into
mainfrom
teal_data@main
Oct 30, 2023
Merged

Introduce teal_data class#925
gogonzo merged 29 commits into
mainfrom
teal_data@main

Conversation

@gogonzo

@gogonzo gogonzo commented Oct 4, 2023

Copy link
Copy Markdown
Contributor

following new teal_data class
@github-actions

github-actions Bot commented Oct 4, 2023

Copy link
Copy Markdown
Contributor

Unit Tests Summary

    1 files    17 suites   17s ⏱️
179 tests 179 ✔️ 0 💤 0
349 runs  349 ✔️ 0 💤 0

Results for commit 2d688f2.

♻️ This comment has been updated with latest results.

@gogonzo gogonzo mentioned this pull request Oct 4, 2023
@gogonzo gogonzo added the core label Oct 5, 2023
@gogonzo gogonzo linked an issue Oct 5, 2023 that may be closed by this pull request
Comment thread R/init.R Outdated
reverting breaking changes and supporting teal_data
Comment thread R/init.R
Comment thread R/module_nested_tabs.R
Comment thread R/module_teal.R Outdated
if (is.null(raw_data())) {
return(NULL)
}
datasets_reactive <- eventReactive(raw_data(), ignoreNULL = TRUE, {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for explicitly setting ignoreNULL to default?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I should remove it because eventReactive has ignoreNULL = TRUE by default, which is exactly what we need here.

@github-actions

github-actions Bot commented Oct 19, 2023

Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------
R/dummy_functions.R                 84      50  40.48%   9-71
R/get_rcode_utils.R                 46       1  97.83%   49
R/include_css_js.R                  24       0  100.00%
R/init.R                            86      34  60.47%   142, 164, 179-186, 191-212, 223-225, 227-229, 231-232
R/landing_popup_module.R            25      25  0.00%    61-87
R/module_filter_manager.R          107      29  72.90%   62-70, 79-84, 228, 233-246
R/module_nested_tabs.R             172      14  91.86%   72, 119, 138-145, 163, 216, 238, 271
R/module_snapshot_manager.R        209     157  24.88%   86-98, 126-135, 139-151, 153-160, 167-181, 185-187, 189-194, 197-207, 210-226, 235-250, 264-287, 290-301, 304-310, 324, 345-368
R/module_tabs_with_filters.R        67       2  97.01%   95, 134
R/module_teal_with_splash.R         53       3  94.34%   64, 70, 100
R/module_teal.R                    135       7  94.81%   68, 71, 158-159, 189-190, 210
R/modules_debugging.R               18      18  0.00%    25-44
R/modules.R                        143      26  81.82%   119, 132, 226-229, 243-248, 259-263, 378-421
R/reporter_previewer_module.R       18       2  88.89%   26, 30
R/show_rcode_modal.R                20      20  0.00%    16-37
R/tdata.R                           39       1  97.44%   158
R/teal_reporter.R                   60       5  91.67%   65, 116-117, 120, 137
R/teal_slices-store.R               25       0  100.00%
R/teal_slices.R                     59      12  79.66%   135-148
R/utils.R                           71       8  88.73%   128-135
R/validate_inputs.R                 32       0  100.00%
R/validations.R                     60      37  38.33%   111-373
R/zzz.R                             11       7  36.36%   3-14
TOTAL                             1564     458  70.72%

Diff against main

Filename                        Stmts    Miss  Cover
----------------------------  -------  ------  -------
R/dummy_functions.R                -4     -13  +12.07%
R/init.R                           -7      +2  -5.13%
R/module_nested_tabs.R             +2      -2  +1.27%
R/module_tabs_with_filters.R        0      +1  -1.49%
R/module_teal_with_splash.R       +20      +1  +0.40%
R/module_teal.R                   -20       0  -0.67%
R/modules.R                         0      +2  -1.40%
R/tdata.R                          -2      -1  +2.31%
R/utils.R                         +38      +8  -11.27%
TOTAL                             +27      -2  +0.64%

Results for commit: 2d688f2

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Comment thread R/init.R
Comment thread R/utils.R Outdated
Comment thread R/module_teal_with_splash.R Outdated
Comment on lines 69 to 71
# raw_data contains TealDataAbstract, i.e. R6 object and container for data
# reactive to get data through delayed loading
# we must leave it inside the server because of callModule which needs to pick up the right session

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this still true?

Comment thread R/module_teal_with_splash.R Outdated
Comment thread R/utils.R Outdated
Comment thread R/utils.R
fix 1 after merge
fix 2 after merge
teal_data instead of new_teal_data
remove generic get_join_keys (duplicated with teal.data)
@m7pr

m7pr commented Oct 25, 2023

Copy link
Copy Markdown
Collaborator

that's a great simplification to the data specification where one does no longer need to use dataset() function and does not need to pass dataname parameter but the name of the arguments are used. Mainly understood changes from the edits in vignettes and examples.

Comment thread R/init.R
Comment thread R/init.R Outdated
Comment thread R/init.R Outdated
Comment thread R/module_teal_with_splash.R
gogonzo and others added 8 commits October 27, 2023 08:08
fix pkgdown
resolve_modules_datanames to utils.R
fix spelling
skipping lint of a long function
addressing old comments

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should init accept empty teal_data?
Currently does but then error is raised by init_filtered_data downstream.

Comment thread vignettes/adding-support-for-reporting.Rmd Outdated
Signed-off-by: Aleksander Chlebowski <114988527+chlebowa@users.noreply.github.com>
@gogonzo
gogonzo merged commit 278488b into main Oct 30, 2023
@gogonzo
gogonzo deleted the teal_data@main branch October 30, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[summary] data refactor

5 participants