Skip to content

Refactor - #440

Closed
gogonzo wants to merge 9 commits into
mainfrom
refactor
Closed

Refactor#440
gogonzo wants to merge 9 commits into
mainfrom
refactor

Conversation

@gogonzo

@gogonzo gogonzo commented Aug 16, 2023

Copy link
Copy Markdown
Contributor

WIP

  • constructor init_filtered_data.tdata will be removed. teal should call default method. init_filtered_data.tdata is introduced as a convenience during a POC coding.

@github-actions

github-actions Bot commented Sep 20, 2023

Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------------------------------------
R/calls_combine_by.R              8       0  100.00%
R/choices_labeled.R              49      14  71.43%   22, 33, 38, 48-53, 65, 69-73
R/count_labels.R                 98       0  100.00%
R/filter_panel_api.R             37       2  94.59%   92, 104
R/FilteredData-utils.R          110      17  84.55%   93-98, 191, 213-222
R/FilteredData.R                588     222  62.24%   167, 522-530, 599-608, 630, 651-692, 710-713, 729, 770-803, 818-820, 824-830, 856-884, 906-908, 912-914, 917-928, 932-941, 943-969, 987-1057, 1099, 1122-1144
R/FilteredDataset-utils.R        20       1  95.00%   133
R/FilteredDataset.R             179      67  62.57%   50, 149, 198-204, 232-289, 329-331
R/FilteredDatasetDefault.R      121       9  92.56%   69, 131, 141, 145, 228-232
R/FilteredDatasetMAE.R          134      37  72.39%   27, 113-118, 157-162, 166-167, 187-209
R/FilterPanelAPI.R               10       0  100.00%
R/FilterState-utils.R            97       1  98.97%   286
R/FilterState.R                 361      61  83.10%   88, 212, 230-234, 241-242, 256-257, 263-264, 312, 314, 316, 368, 412, 644, 687-712, 723-742, 777-783, 792-798
R/FilterStateChoices.R          338     106  68.64%   302-305, 317, 360, 384-391, 395-412, 441, 456-467, 479-487, 491-520, 541-544, 547-550, 561-582, 595-596, 606
R/FilterStateDate.R             212     129  39.15%   219, 272-430
R/FilterStateDatettime.R        307     199  35.18%   256, 309-541
R/FilterStateEmpty.R             63      41  34.92%   82, 92-97, 111, 125-176
R/FilterStateExpr.R              75      62  17.33%   138-262
R/FilterStateLogical.R          196     144  26.53%   127, 150, 210, 213-399
R/FilterStateRange.R            410     105  74.39%   254, 378, 506-510, 513-523, 526, 538-544, 555-567, 571-581, 585-587, 601-628, 643, 646, 661-678, 713-718, 728-730
R/FilterStates-utils.R           70       9  87.14%   102, 121, 179-185, 207, 234
R/FilterStates.R                364      30  91.76%   76-80, 189, 320-329, 417-420, 463, 548-552, 597, 718-721
R/FilterStatesDF.R                5       0  100.00%
R/FilterStatesMAE.R              10       1  90.00%   39
R/FilterStatesMatrix.R            3       0  100.00%
R/FilterStatesSE.R              211     157  25.59%   34, 69-71, 81-83, 107-114, 122-129, 152-300
R/include_css_js.R                5       5  0.00%    12-16
R/teal_slice-store.R              7       7  0.00%    28-57
R/teal_slice.R                  102       2  98.04%   133, 197
R/teal_slices.R                 139       6  95.68%   140-145, 325
R/test_utils.R                   21       0  100.00%
R/utils.R                        49       2  95.92%   101-102
R/variable_types.R               48      33  31.25%   41-46, 56, 69-104
R/zzz.R                          15      15  0.00%    3-46
TOTAL                          4462    1484  66.74%

Diff against main

Filename                  Stmts    Miss  Cover
----------------------  -------  ------  -------
R/FilteredData-utils.R       -7       0  -0.92%
R/FilteredData.R              0      -4  +0.68%
TOTAL                        -7      -4  +0.04%

Results for commit: 617a618

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions

github-actions Bot commented Sep 20, 2023

Copy link
Copy Markdown
Contributor

Unit Tests Summary

    1 files    28 suites   27s ⏱️
371 tests 371 ✔️ 0 💤 0
846 runs  846 ✔️ 0 💤 0

Results for commit 79d756e.

♻️ This comment has been updated with latest results.

tdata -> teal_data
export method for teal_data
@gogonzo

gogonzo commented Oct 4, 2023

Copy link
Copy Markdown
Contributor Author

closing in favour of #470 470

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants