Skip to content

get_code to return concatenated code string and removed format_expression - #206

Merged
kartikeyakirar merged 4 commits into
refactorfrom
173_fix_get_code@refactor
Nov 29, 2023
Merged

get_code to return concatenated code string and removed format_expression#206
kartikeyakirar merged 4 commits into
refactorfrom
173_fix_get_code@refactor

Conversation

@kartikeyakirar

@kartikeyakirar kartikeyakirar commented Nov 27, 2023

Copy link
Copy Markdown
Contributor

@kartikeyakirar
kartikeyakirar changed the base branch from main to refactor November 27, 2023 13:28
@kartikeyakirar kartikeyakirar mentioned this pull request Nov 27, 2023
Merged
6 tasks
@github-actions

github-actions Bot commented Nov 27, 2023

Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename                       Stmts    Miss  Cover    Missing
---------------------------  -------  ------  -------  ------------------------
R/cdisc_data.R                     1       1  0.00%    37
R/data_label.R                    24       5  79.17%   33-37, 103
R/datanames.R                     10       0  100.00%
R/default_cdisc_join_keys.R       23      19  17.39%   17-35, 55-62
R/deprecated.R                    61      61  0.00%    16-320
R/dummy_function.R                 5       5  0.00%    16-23
R/formatters_var_labels.R         49      49  0.00%    28-151
R/join_key.R                      31       0  100.00%
R/join_keys-c.R                   26       0  100.00%
R/join_keys-extract.R            122       0  100.00%
R/join_keys-names.R               15       0  100.00%
R/join_keys-parents.R             28       1  96.43%   28
R/join_keys-print.R               46       0  100.00%
R/join_keys-utils.R               87       2  97.70%   127, 130
R/join_keys.R                     21       0  100.00%
R/teal_data-class.R               25       1  96.00%   70
R/teal_data-get_code.R            15       3  80.00%   39, 50, 55
R/teal_data-show.R                 4       4  0.00%    13-18
R/teal_data.R                     22       9  59.09%   32, 41-47, 50
R/testhat-helpers.R               26       0  100.00%
R/topological_sort.R              32       0  100.00%
R/utils-code_dependency.R        192       7  96.35%   37, 42, 252-253, 321-324
R/utils.R                          8       0  100.00%
R/verify.R                        42      11  73.81%   68, 98-102, 105-109
R/zzz.R                           10      10  0.00%    4-16
TOTAL                            925     188  79.68%

Diff against main

Filename                       Stmts    Miss  Cover
---------------------------  -------  ------  --------
R/cdisc_data.R                   -40       0  -97.56%
R/data_label.R                   -12      -8  +15.28%
R/datanames.R                     -1       0  +100.00%
R/default_cdisc_join_keys.R      +23     +19  +17.39%
R/deprecated.R                   +61     +61  +100.00%
R/dummy_function.R                 0      +4  -80.00%
R/formatters_var_labels.R          0     +28  -57.14%
R/join_key.R                      -1       0  +100.00%
R/join_keys-parents.R              0      +1  -3.57%
R/join_keys-print.R               -1       0  +100.00%
R/join_keys-utils.R                0      +1  -1.15%
R/join_keys.R                     -2       0  +100.00%
R/teal_data-class.R               +2       0  +0.35%
R/teal_data-get_code.R           +15      +3  +80.00%
R/teal_data-show.R                +4      +4  +100.00%
R/teal_data.R                    -17      +7  -35.78%
R/testhat-helpers.R              -27       0  +100.00%
R/utils.R                        -48      -9  +16.07%
R/verify.R                       +42     +11  +73.81%
R/zzz.R                           -1      -1  +100.00%
TOTAL                             -3    +121  +2.43%

Results for commit: 848eefb

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions

github-actions Bot commented Nov 27, 2023

Copy link
Copy Markdown
Contributor

Unit Tests Summary

    1 files    15 suites   1s ⏱️
165 tests 165 ✔️ 0 💤 0 ❌
245 runs  245 ✔️ 0 💤 0 ❌

Results for commit 848eefb.

@github-actions

github-actions Bot commented Nov 27, 2023

Copy link
Copy Markdown
Contributor

Unit Test Performance Difference

Test suite performance difference
Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
CDISCTealDataConnector 💀 $0.20$ $-0.20$ $-21$ $0$ $0$ $0$
CDISCTealDataset 💀 $0.16$ $-0.16$ $-10$ $0$ $0$ $0$
CDISCTealDatasetConnector 💀 $0.05$ $-0.05$ $-7$ $0$ $0$ $0$
CallableCode 💀 $0.19$ $-0.19$ $-12$ $0$ $0$ $0$
CallableFunction 💀 $0.64$ $-0.64$ $-62$ $0$ $0$ $0$
CodeClass 💀 $0.16$ $-0.16$ $-27$ $0$ $0$ $0$
MAETealDataset 💀 $6.25$ $-6.25$ $-27$ $-1$ $0$ $0$
TealData 💀 $0.56$ $-0.56$ $-73$ $0$ $0$ $0$
TealDataAbstract 💀 $0.83$ $-0.83$ $-67$ $0$ $0$ $0$
TealDataConnection 💀 $0.08$ $-0.08$ $-16$ $0$ $0$ $0$
TealDataConnector 💀 $0.06$ $-0.06$ $-8$ $0$ $0$ $0$
TealDataset 💀 $0.75$ $-0.75$ $-124$ $0$ $0$ $0$
TealDatasetConnector 💀 $2.46$ $-2.46$ $-194$ $0$ $0$ $0$
TealDatasetConnector_constructors 💀 $0.01$ $-0.01$ $-1$ $0$ $0$ $0$
as_cdisc 💀 $0.03$ $-0.03$ $-8$ $0$ $0$ $0$
check_ellipsis 💀 $0.07$ $-0.07$ $-18$ $0$ $0$ $0$
get_code 💀 $0.12$ $-0.12$ $-22$ $0$ $0$ $0$
get_code_dataname 💀 $0.11$ $-0.11$ $-22$ $0$ $0$ $0$
get_join_keys 💀 $0.03$ $-0.03$ $-2$ $0$ $0$ $0$
get_raw_data 💀 $0.10$ $-0.10$ $-18$ $0$ $0$ $0$
is_pulled 💀 $0.03$ $-0.03$ $-4$ $0$ $0$ $0$
to_relational_data 💀 $0.24$ $-0.24$ $-42$ $0$ $0$ $0$
utils 💀 $0.11$ $-0.11$ $-19$ $0$ $0$ $0$
verify 👶 $+0.07$ $+8$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
CDISCTealDataConnector 💀 $0.05$ $-0.05$ TealDataConnector_with_custom_UI_and_server
CDISCTealDataConnector 💀 $0.01$ $-0.01$ cdisc_data_connector_returns_a_CDISCTealDataConnector_object_on_basic_input
CDISCTealDataConnector 💀 $0.01$ $-0.01$ cdisc_data_connector_validates_the_connection_and_connectors_arguments
CDISCTealDataConnector 💀 $0.13$ $-0.13$ get_code_returns_the_correct_code_for_two_CDISCTealDatasetConnector_objects
CDISCTealDataset 💀 $0.03$ $-0.03$ CDISCTealDataset_basics
CDISCTealDataset 💀 $0.01$ $-0.01$ CDISCTealDataset_print_method_returns_correct_class_name_and_content
CDISCTealDataset 💀 $0.05$ $-0.05$ Case_1_CDISCTealDataset_get_code_does_not_return_duplicated_code_when_CDISCTealDataset_mutate_method_is_called
CDISCTealDataset 💀 $0.07$ $-0.07$ Case_2_CDISCTealDataset_get_code_does_not_return_duplicated_code_when_CDISCTealDataset_mutate_method_is_called
CDISCTealDataset 💀 $0.00$ $-0.00$ data_returns_the_data_passed_in_the_constructor
CDISCTealDataset 💀 $0.01$ $-0.01$ get_dataname_returns_the_dataname_passed_to_the_constructor
CDISCTealDatasetConnector 💀 $0.04$ $-0.04$ Single_dataset_connector
CDISCTealDatasetConnector 💀 $0.01$ $-0.01$ TealDatasetConnector_print_prints_out_expected_output_of_class_and_content
CallableCode 💀 $0.01$ $-0.01$ CallableCode_can_use_objects_from_namespaces_other_than_global
CallableCode 💀 $0.15$ $-0.15$ Objects_can_be_generated_from_the_code
CallableCode 💀 $0.03$ $-0.03$ callable_code_throws_an_error_when_supplied_code_is_not_valid
CallableCode 💀 $0.01$ $-0.01$ get_call_transforms_double_new_lines_into_one_new_line
CallableCode 💀 $0.01$ $-0.01$ run_throws_an_error_when_an_object_referenced_in_the_code_is_not_found
CallableFunction 💀 $0.00$ $-0.00$ CallableFunction_returns_the_correct_name_if_passed_a_Primitive_directly
CallableFunction 💀 $0.01$ $-0.01$ CallableFunction_returns_the_correct_name_if_passed_a_base_function_directly
CallableFunction 💀 $0.00$ $-0.00$ CallableFunction_returns_the_correct_name_if_passed_a_function_from_global_env_indirectly
CallableFunction 💀 $0.01$ $-0.01$ CallableFunction_returns_the_correct_name_if_passed_a_function_name_indirectly
CallableFunction 💀 $0.05$ $-0.05$ CallableFunction_returns_the_correct_name_if_passed_a_generic_from_a_namespace
CallableFunction 💀 $0.01$ $-0.01$ CallableFunction_returns_the_correct_name_if_passed_a_name_of_a_base_function
CallableFunction 💀 $0.01$ $-0.01$ CallableFunction_returns_the_correct_name_if_passed_a_namespace_function_indirectly
CallableFunction 💀 $0.01$ $-0.01$ CallableFunction_returns_the_correct_name_if_passed_a_prefixed_name_of_a_function
CallableFunction 💀 $0.00$ $-0.00$ CallableFunction_returns_the_correct_name_if_passed_an_anonymous_function
CallableFunction 💀 $0.02$ $-0.02$ CallableFunction_throws_an_error_if_passed_a_Primitive_by_character
CallableFunction 💀 $0.01$ $-0.01$ CallableFunction_throws_an_error_if_passed_a_namespace_function_via_a_binding_in_the_parent_frame
CallableFunction 💀 $0.01$ $-0.01$ CallableFunction_throws_an_error_if_passed_a_prefixed_object_not_a_function_
CallableFunction 💀 $0.13$ $-0.13$ Function_found
CallableFunction 💀 $0.04$ $-0.04$ Test_callable
CallableFunction 💀 $0.02$ $-0.02$ Test_inputs
CallableFunction 💀 $0.01$ $-0.01$ get_binding_name_throws_if_the_function_could_not_be_found_in_the_environment
CallableFunction 💀 $0.02$ $-0.02$ is_failed
CallableFunction 💀 $0.05$ $-0.05$ test_callable_errors
CallableFunction 💀 $0.22$ $-0.22$ test_cloning
CodeClass 💀 $0.01$ $-0.01$ Basic_example_CodeClass
CodeClass 💀 $0.01$ $-0.01$ CodeClass_append
CodeClass 💀 $0.01$ $-0.01$ CodeClass_append_deps
CodeClass 💀 $0.03$ $-0.03$ CodeClass_list_to_code_class
CodeClass 💀 $0.00$ $-0.00$ Duplicated_code_is_appended_if_it_doesn_t_have_a_dataname
CodeClass 💀 $0.00$ $-0.00$ Duplicated_code_is_appended_if_its_dataname_is_different
CodeClass 💀 $0.01$ $-0.01$ Duplicated_code_is_not_appended_if_its_dataname_is_duplicated
CodeClass 💀 $0.01$ $-0.01$ Exception_handling_with_dataname_of_xyz
CodeClass 💀 $0.00$ $-0.00$ example_datasets
CodeClass 💀 $0.02$ $-0.02$ example_datasets_deps
CodeClass 💀 $0.04$ $-0.04$ list_to_code_class_assigning_dataname_to_the_object_name_inside_of_the_list
MAETealDataset 💀 $0.06$ $-0.06$ Error_raised_executing_MAETealDataset_check_keys_and_duplicate_rows_found_in_key_columns
MAETealDataset 💀 $0.08$ $-0.08$ Error_raised_when_executing_MAETealDataset_check_and_code_is_empty
MAETealDataset 💀 $0.15$ $-0.15$ FALSE_returned_when_executing_MAETealDataset_check_and_code_is_not_correct
MAETealDataset 💀 $0.04$ $-0.04$ MAETealDataset_check_keys_doesn_t_throw_if_constructed_with_correct_keys
MAETealDataset 💀 $0.07$ $-0.07$ MAETealDataset_check_keys_throws_if_constructed_with_keys_not_present_in_colData
MAETealDataset 💀 $0.17$ $-0.17$ MAETealDataset_check_returns_TRUE_when_constructed_with_the_correct_code
MAETealDataset 💀 $5.12$ $-5.12$ MAETealDataset_constructors_do_not_raise_exceptions
MAETealDataset 💀 $0.09$ $-0.09$ MAETealDataset_getters_and_setters
MAETealDataset 💀 $0.05$ $-0.05$ MAETealDataset_is_pulled_returns_true
MAETealDataset 💀 $0.20$ $-0.20$ MAETealDataset_recreate_updates_the_class_fields
MAETealDataset 💀 $0.17$ $-0.17$ dataset_constructor_returns_the_same_as_MAETealDataset_new_
MAETealDataset 💀 $0.04$ $-0.04$ dataset_does_not_throw_when_passed_a_MultiAssayExperiment_object
TealData 💀 $0.08$ $-0.08$ Multiple_connectors
TealData 💀 $0.02$ $-0.02$ TealData_check_metadata_does_not_produce_error_if_join_keys_are_consistent_for_given_datasets
TealData 💀 $0.03$ $-0.03$ TealData_check_metadata_fails_if_inconsistent_join_keys_for_given_datasets
TealData 💀 $0.01$ $-0.01$ TealData_check_metadata_returns_error_when_a_column_in_the_keys_is_not_found
TealData 💀 $0.01$ $-0.01$ TealData_get_connectors_returns_a_list_with_the_numbers_of_connectors_provided
TealData 💀 $0.01$ $-0.01$ TealData_get_connectors_returns_an_empty_list_if_no_connectors_are_provided
TealData 💀 $0.01$ $-0.01$ TealData_get_items_returns_a_dataset_of_the_passed_dataset_name
TealData 💀 $0.01$ $-0.01$ TealData_get_items_returns_a_list_of_the_contents_if_no_dataname_is_defined
TealData 💀 $0.01$ $-0.01$ TealData_get_items_returns_the_content_of_the_passed_TealDataConnector_name
TealData 💀 $0.01$ $-0.01$ TealData_get_items_throws_an_error_if_the_desired_dataset_is_not_found
TealData 💀 $0.01$ $-0.01$ TealData_get_join_keys_returns_all_join_keys_of_the_single_dataname_specified
TealData 💀 $0.01$ $-0.01$ TealData_get_join_keys_returns_all_join_keys_when_no_input_datanme_is_specified
TealData 💀 $0.01$ $-0.01$ TealData_get_join_keys_returns_an_empty_joinKeys_if_no_join_keys_are_passed
TealData 💀 $0.01$ $-0.01$ TealData_get_join_keys_returns_the_join_keys_of_the_specified_datanames
TealData 💀 $0.01$ $-0.01$ TealData_get_parents_returns_an_empty_list_even_when_parents_are_specified
TealData 💀 $0.02$ $-0.02$ TealData_keeps_references_to_the_objects_passed_to_the_constructor
TealData 💀 $0.01$ $-0.01$ TealData_mutate_join_keys_changes_keys_for_both_datasets_same_key_in_both_
TealData 💀 $0.01$ $-0.01$ TealData_mutate_join_keys_returns_a_join_keys_object_with_the_updated_join_keys
TealData 💀 $0.01$ $-0.01$ TealData_new_sets_join_keys_datasets_based_on_the_passed_join_keys_input_otherwise_empty
TealData 💀 $0.02$ $-0.02$ TealData_new_sets_pull_and_mutate_code_as_empty_CodeClass
TealData 💀 $0.02$ $-0.02$ TealData_new_throws_if_data_is_not_valid
TealData 💀 $0.01$ $-0.01$ TealData_print_prints_out_expected_output_on_basic_input
TealData 💀 $0.14$ $-0.14$ TealData_with_mutliple_datasets_and_connectors
TealData 💀 $0.05$ $-0.05$ TealData_with_single_dataset_and_connector
TealData 💀 $0.03$ $-0.03$ copy_deep_TRUE_deep_copies_self_and_the_items
TealData 💀 $0.02$ $-0.02$ copy_deep_TRUE_keeps_valid_references_between_items
TealDataAbstract 💀 $0.01$ $-0.01$ TealDataAbstract_cannot_be_instantiated
TealDataAbstract 💀 $0.01$ $-0.01$ check_combined_code_returns_TRUE_when_the_code_is_reproducible
TealDataAbstract 💀 $0.01$ $-0.01$ check_combined_code_returns_error_when_the_code_is_not_reproducible
TealDataAbstract 💀 $0.01$ $-0.01$ check_combined_code_returns_error_when_the_code_is_not_supplied
TealDataAbstract 💀 $0.01$ $-0.01$ check_names_throws_if_passed_two_datasets_with_the_same_name
TealDataAbstract 💀 $0.02$ $-0.02$ check_reproducibility_passes_if_the_reproducibility_check_passes
TealDataAbstract 💀 $0.01$ $-0.01$ check_reproducibility_throws_error_if_reproducibility_check_does_not_pass
TealDataAbstract 💀 $0.01$ $-0.01$ check_returns_FALSE_if_the_code_provided_in_datasets_does_not_reproduce_them
TealDataAbstract 💀 $0.01$ $-0.01$ check_returns_NULL_if_the_check_parameter_is_false
TealDataAbstract 💀 $0.01$ $-0.01$ check_returns_TRUE_if_the_code_is_reproducible
TealDataAbstract 💀 $0.01$ $-0.01$ check_throws_an_error_when_one_of_the_passed_datasets_has_empty_code
TealDataAbstract 💀 $0.01$ $-0.01$ execute_mutate_returns_current_datasets_if_no_mutate_code
TealDataAbstract 💀 $0.02$ $-0.02$ execute_mutate_returns_updated_datasets
TealDataAbstract 💀 $0.01$ $-0.01$ get_check_result_method_returns_NULL_if_check_is_set_to_FALSE
TealDataAbstract 💀 $0.02$ $-0.02$ get_check_result_method_returns_TRUE_if_check_passed
TealDataAbstract 💀 $0.03$ $-0.03$ get_check_returns_the_check_status
TealDataAbstract 💀 $0.01$ $-0.01$ get_code_class_with_FALSE_returns_code_with_mutate_code
TealDataAbstract 💀 $0.01$ $-0.01$ get_code_class_with_TRUE_returns_code_without_mutate_code
TealDataAbstract 💀 $0.01$ $-0.01$ get_code_returns_the_code_of_the_dataset_specifed
TealDataAbstract 💀 $0.02$ $-0.02$ get_code_returns_the_code_of_the_datasets_when_no_input_is_specified
TealDataAbstract 💀 $0.01$ $-0.01$ get_code_returns_the_non_deparsed_code_when_deparse_is_set_to_FALSE
TealDataAbstract 💀 $0.02$ $-0.02$ get_code_throws_error_if_dataname_is_not_character_or_deparse_is_not_logical
TealDataAbstract 💀 $0.01$ $-0.01$ get_datanames_returns_a_vector_of_characters
TealDataAbstract 💀 $0.01$ $-0.01$ get_datanames_throws_error_if_an_argument_is_passed
TealDataAbstract 💀 $0.04$ $-0.04$ get_dataset_returns_a_list_of_all_datasets_if_passed_NULL
TealDataAbstract 💀 $0.02$ $-0.02$ get_dataset_returns_the_dataset_with_the_passed_name
TealDataAbstract 💀 $0.01$ $-0.01$ get_dataset_throws_an_error_if_no_dataset_is_found_with_the_passed_name
TealDataAbstract 💀 $0.01$ $-0.01$ get_dataset_throws_an_error_if_passed_name_is_not_character
TealDataAbstract 💀 $0.01$ $-0.01$ get_datasets_code_class_returns_a_CodeClass_object_with_the_code_passed
TealDataAbstract 💀 $0.01$ $-0.01$ get_datasets_code_class_returns_an_empty_CodeClass_object_when_no_code_is_passed
TealDataAbstract 💀 $0.04$ $-0.04$ get_datasets_returns_a_list_of_all_datasets_if_passed_NULL
TealDataAbstract 💀 $0.01$ $-0.01$ get_datasets_throws_an_error_is_a_dataset_is_not_pulled_yet
TealDataAbstract 💀 $0.07$ $-0.07$ get_items_returns_all_items_in_TealDataAbstract_object_when_no_input_dataname_is_specified
TealDataAbstract 💀 $0.02$ $-0.02$ get_items_returns_the_item_of_the_specified_input_dataname
TealDataAbstract 💀 $0.01$ $-0.01$ get_items_throws_error_if_dataname_is_not_found
TealDataAbstract 💀 $0.01$ $-0.01$ get_pull_code_class_gets_code_correctly
TealDataAbstract 💀 $0.02$ $-0.02$ is_pulled_returns_if_the_datasets_are_pulled
TealDataAbstract 💀 $0.01$ $-0.01$ mutate_dataset_throws_an_error_if_the_dataname_is_not_character
TealDataAbstract 💀 $0.01$ $-0.01$ mutate_dataset_throws_an_error_if_the_dataname_is_not_found
TealDataAbstract 💀 $0.02$ $-0.02$ mutate_dataset_updates_the_code_of_the_dataset
TealDataAbstract 💀 $0.02$ $-0.02$ mutate_updates_the_code
TealDataAbstract 💀 $0.02$ $-0.02$ reassign_datasets_vars_updates_the_references_of_vars_in_items_according_to_items_addresses
TealDataAbstract 💀 $0.01$ $-0.01$ set_check_accepts_only_logical_input
TealDataAbstract 💀 $0.01$ $-0.01$ set_check_sets_the_reproducibility_check
TealDataAbstract 💀 $0.02$ $-0.02$ set_mutate_code_accepts_character_code_of_length_1
TealDataAbstract 💀 $0.01$ $-0.01$ set_mutate_code_updates_the_object_code
TealDataAbstract 💀 $0.02$ $-0.02$ set_mutate_vars_accepts_a_unique_names_list_throws_error_otherwise
TealDataAbstract 💀 $0.01$ $-0.01$ set_mutate_vars_appends_the_new_mutate_vars
TealDataAbstract 💀 $0.01$ $-0.01$ set_pull_code_sets_code_correctly
TealDataAbstract 💀 $0.05$ $-0.05$ set_pull_code_throws_error_if_TealDataAbstract_has_only_connectors
TealDataAbstract 💀 $0.01$ $-0.01$ set_pull_code_throws_error_if_code_is_not_character
TealDataAbstract 💀 $0.01$ $-0.01$ set_pull_code_throws_error_if_code_is_specified_on_data_and_dataset_levels
TealDataConnection 💀 $0.00$ $-0.00$ TealDataConnection_can_be_initialized
TealDataConnection 💀 $0.00$ $-0.00$ TealDataConnection_set_close_server_accepts_the_new_Shiny_module_definition
TealDataConnection 💀 $0.00$ $-0.00$ TealDataConnection_set_close_server_accepts_the_old_Shiny_module_definition
TealDataConnection 💀 $0.00$ $-0.00$ TealDataConnection_set_open_server_accepts_the_new_Shiny_module_definition
TealDataConnection 💀 $0.00$ $-0.00$ TealDataConnection_set_open_server_accepts_the_old_Shiny_module_definition
TealDataConnection 💀 $0.00$ $-0.00$ TealDataConnection_set_preopen_server_accepts_the_new_Shiny_module_definition
TealDataConnection 💀 $0.00$ $-0.00$ TealDataConnection_set_preopen_server_accepts_the_old_Shiny_module_definition
TealDataConnection 💀 $0.04$ $-0.04$ data_connection
TealDataConnection 💀 $0.02$ $-0.02$ data_connection_returns_a_TealDataConnection_object_on_basic_input
TealDataConnector 💀 $0.01$ $-0.01$ TealDataConnector_print_prints_out_expected_output_on_basic_input
TealDataConnector 💀 $0.04$ $-0.04$ TealDataConnector_with_TealDataConnection
TealDataConnector 💀 $0.01$ $-0.01$ relational_data_connector_has_input_validation
TealDataConnector 💀 $0.01$ $-0.01$ relational_data_connector_returns_a_TealDataConnector_object_on_basic_input
TealDataset 💀 $0.02$ $-0.02$ Dupliated_mutation_code_is_shown_via_get_code_
TealDataset 💀 $0.02$ $-0.02$ TealDataset_active_bindings_and_getters
TealDataset 💀 $0.03$ $-0.03$ TealDataset_basics
TealDataset 💀 $0.08$ $-0.08$ TealDataset_check_method
TealDataset 💀 $0.01$ $-0.01$ TealDataset_check_returns_FALSE_if_the_passed_code_creates_a_binding_with_a_different_object
TealDataset 💀 $0.01$ $-0.01$ TealDataset_get___colnames
TealDataset 💀 $0.00$ $-0.00$ TealDataset_get_rownames
TealDataset 💀 $0.01$ $-0.01$ TealDataset_is_mutate_delayed_returns_TRUE_if_the_TealDataset_s_dependency_is_delayed
TealDataset 💀 $0.02$ $-0.02$ TealDataset_is_mutate_delayed_stays_FALSE_if_the_TealDataset_s_dependency_turns_from_not_delayed_to_delayed
TealDataset 💀 $0.12$ $-0.12$ TealDataset_mutate_method_with_delayed_logic
TealDataset 💀 $0.00$ $-0.00$ TealDataset_recreate
TealDataset 💀 $0.01$ $-0.01$ TealDataset_recreate_does_not_reset_the_mutation_code
TealDataset 💀 $0.01$ $-0.01$ TealDataset_recreate_does_not_reset_the_variables_needed_for_mutation
TealDataset 💀 $0.05$ $-0.05$ TealDataset_set_vars_throws_an_error_if_passed_the_enclosing_TealDatasetConnector
TealDataset 💀 $0.01$ $-0.01$ TealDataset_set_vars_throws_an_error_if_passed_the_enclosing_TealDataset_object_directly
TealDataset 💀 $0.01$ $-0.01$ TealDataset_set_vars_throws_an_error_if_passed_the_enclosing_TealDataset_object_indirectly_distance_1
TealDataset 💀 $0.01$ $-0.01$ TealDataset_set_vars_throws_an_error_if_passed_the_enclosing_TealDataset_object_indirectly_distance_2
TealDataset 💀 $0.01$ $-0.01$ TealDataset_supplementary_constructors
TealDataset 💀 $0.01$ $-0.01$ clone_deep_TRUE_deep_clones_dependencies_which_are_TealDataset_objects
TealDataset 💀 $0.01$ $-0.01$ dataset_print_prints_out_all_rows_when_less_than_6
TealDataset 💀 $0.01$ $-0.01$ dataset_print_truncates_output_after_6_rows
TealDataset 💀 $0.01$ $-0.01$ dataset_print_warns_of_superfluous_arguments
TealDataset 💀 $0.01$ $-0.01$ get_code_class_returns_the_correct_CodeClass_after_mutating_with_another_TealDataset
TealDataset 💀 $0.02$ $-0.02$ get_code_class_returns_the_correct_CodeClass_object
TealDataset 💀 $0.00$ $-0.00$ get_var_r6_returns_identical_R6_objects_as_passed_with_set_vars
TealDataset 💀 $0.02$ $-0.02$ metadata_can_be_NULL_the_default_
TealDataset 💀 $0.01$ $-0.01$ metadata_not_a_list_of_length_one_atomics_throws_an_error
TealDataset 💀 $0.01$ $-0.01$ metadata_not_a_list_throws_an_error
TealDataset 💀 $0.11$ $-0.11$ mutate_dataset
TealDataset 💀 $0.09$ $-0.09$ mutate_dataset_with_vars_argument
TealDataset 💀 $0.01$ $-0.01$ reassign_datasets_vars_does_not_change_any_vars_while_empty_list_is_provided
TealDataset 💀 $0.01$ $-0.01$ reassign_datasets_vars_does_not_change_vars_elements_of_class_different_than_TealDataset_and_TealDatasetConnector
TealDataset 💀 $0.01$ $-0.01$ reassign_datasets_vars_updates_the_references_of_the_vars_r6_to_addresses_of_passed_objects
TealDataset 💀 $0.01$ $-0.01$ reassign_datasets_vars_updates_the_references_of_the_vars_to_addresses_of_passed_objects
TealDatasetConnector 💀 $0.01$ $-0.01$ Callable_metadata_is_pulled_when_data_is_pulled
TealDatasetConnector 💀 $0.02$ $-0.02$ Identical_mutation_expressions_are_added_to_the_mutation_code
TealDatasetConnector 💀 $0.01$ $-0.01$ Identical_mutation_expressions_are_executed_upon_pulling_the_Connector_object
TealDatasetConnector 💀 $0.01$ $-0.01$ Identical_mutation_expressions_are_shown_in_the_returned_code_after_pulling
TealDatasetConnector 💀 $0.04$ $-0.04$ Initializing_TealDatasetConnector_with_code_argument_works
TealDatasetConnector 💀 $0.01$ $-0.01$ Pulled_TealDatasetConnector_returns_the_same_CodeClass_as_before_pulling
TealDatasetConnector 💀 $0.01$ $-0.01$ Pulled_dependent_TealDatasetConnector_returns_the_same_CodeClass_as_before_pulling
TealDatasetConnector 💀 $0.01$ $-0.01$ Pulling_an_already_pulled_TealDatasetConnector_after_mutating_it_with_a_delayed_object_does_not_change_the_returned_code
TealDatasetConnector 💀 $0.01$ $-0.01$ Pulling_an_already_pulled_TealDatasetConnector_after_mutating_it_with_a_delayed_object_undoes_any_eager_pre_pull_mutations
TealDatasetConnector 💀 $0.02$ $-0.02$ Pulling_twice_doesn_t_change_the_returned_TealDatasetConnector_s_CodeClass_
TealDatasetConnector 💀 $0.09$ $-0.09$ TealDatasetConnector
TealDatasetConnector 💀 $0.01$ $-0.01$ TealDatasetConnector_is_mutate_delayed_is_FALSE_if_not_yet_pulled_and_not_mutated
TealDatasetConnector 💀 $0.01$ $-0.01$ TealDatasetConnector_is_mutate_delayed_returns_FALSE_if_mutated_with_no_vars_after_pulling
TealDatasetConnector 💀 $0.01$ $-0.01$ TealDatasetConnector_is_mutate_delayed_returns_FALSE_if_pulled_and_not_mutated
TealDatasetConnector 💀 $0.01$ $-0.01$ TealDatasetConnector_is_mutate_delayed_returns_TRUE_if_mutated_with_no_delayed_objects_and_pulled
TealDatasetConnector 💀 $0.01$ $-0.01$ TealDatasetConnector_is_mutate_delayed_returns_TRUE_if_not_pulled_and_mutated
TealDatasetConnector 💀 $0.02$ $-0.02$ TealDatasetConnector_mutate_method_edge_cases
TealDatasetConnector 💀 $0.28$ $-0.28$ TealDatasetConnector_mutate_method_with_delayed_logic
TealDatasetConnector 💀 $0.01$ $-0.01$ TealDatasetConnector_print_does_not_print_dataset_when_not_yet_pulled
TealDatasetConnector 💀 $0.01$ $-0.01$ TealDatasetConnector_print_prints_dataset_when_it_is_pulled
TealDatasetConnector 💀 $0.01$ $-0.01$ TealDatasetConnector_returns_the_correct_code_when_mutated_with_no_vars_after_pulling
TealDatasetConnector 💀 $0.02$ $-0.02$ clone_deep_TRUE_deep_clones_dependencies_which_are_TealDataset_objects
TealDatasetConnector 💀 $0.04$ $-0.04$ code_dataset_connector_Modify_vars
TealDatasetConnector 💀 $0.02$ $-0.02$ code_dataset_connector_Test_various_inputs
TealDatasetConnector 💀 $0.05$ $-0.05$ code_dataset_connector_library_calls
TealDatasetConnector 💀 $0.15$ $-0.15$ csv_cdisc_dataset_connector
TealDatasetConnector 💀 $0.48$ $-0.48$ csv_dataset_connector
TealDatasetConnector 💀 $0.05$ $-0.05$ csv_dataset_connector_attritubes
TealDatasetConnector 💀 $0.14$ $-0.14$ csv_dataset_connector_non_standard_datasets_multi_space_character_delim
TealDatasetConnector 💀 $0.05$ $-0.05$ csv_dataset_connector_not_expected_input
TealDatasetConnector 💀 $0.04$ $-0.04$ fun_cdisc_dataset_connector
TealDatasetConnector 💀 $0.01$ $-0.01$ get_code_class_returns_the_correct_CodeClass_object
TealDatasetConnector 💀 $0.01$ $-0.01$ get_var_r6_returns_identical_objects_as_these_passed_to_the_vars_argument_in_the_constructor
TealDatasetConnector 💀 $0.02$ $-0.02$ if_pulled_metadata_is_invalid_dataset_is_still_created_but_metadata_is_NULL
TealDatasetConnector 💀 $0.03$ $-0.03$ if_pulling_metadata_fails_dataset_is_still_created_but_metadata_is_NULL
TealDatasetConnector 💀 $0.01$ $-0.01$ list_metadata_is_passed_to_dataset_when_data_is_pulled
TealDatasetConnector 💀 $0.02$ $-0.02$ metadata_for_TealDatasetConnector_can_be_Callable_list_or_NULL
TealDatasetConnector 💀 $0.05$ $-0.05$ rds_dataset_connector
TealDatasetConnector 💀 $0.01$ $-0.01$ reassign_datasets_vars_does_not_change_any_vars_while_empty_list_is_provided
TealDatasetConnector 💀 $0.01$ $-0.01$ reassign_datasets_vars_does_not_change_vars_elements_of_class_different_than_TealDataset_and_TealDatasetConnector
TealDatasetConnector 💀 $0.01$ $-0.01$ reassign_datasets_vars_updates_the_references_of_the_vars_r6_to_addresses_of_passed_objects
TealDatasetConnector 💀 $0.01$ $-0.01$ reassign_datasets_vars_updates_the_references_of_the_vars_to_addresses_of_passed_objects
TealDatasetConnector 💀 $0.54$ $-0.54$ script_cdisc_dataset_connector
TealDatasetConnector 💀 $0.03$ $-0.03$ script_dataset_connector
TealDatasetConnector_constructors 💀 $0.01$ $-0.01$ code_dataset_connector_returns_the_same_object_as_TealDatasetConnector
as_cdisc 💀 $0.01$ $-0.01$ as_cdisc_assigns_cdisc_keys_if_dataset_has_no_keys_and_name_matches_cdisc
as_cdisc 💀 $0.01$ $-0.01$ as_cdisc_does_not_assign_cdisc_keys_if_dataset_has_no_keys_but_name_does_not_match_cdisc
as_cdisc 💀 $0.01$ $-0.01$ as_cdisc_does_not_modify_a_cdisc_flavoured_object
as_cdisc 💀 $0.01$ $-0.01$ as_cdisc_passes_keys_from_dataset_to_cdisc_dataset
as_cdisc 💀 $0.01$ $-0.01$ as_cdisc_passes_metadata_from_dataset_to_cdisc_dataset
cdisc_data 💀 $0.07$ $-0.07$ Basic_example_check_overall_code
cdisc_data 💀 $0.02$ $-0.02$ Basic_example_without_code_and_check
cdisc_data 💀 $0.16$ $-0.16$ List_values
cdisc_data 💀 $0.05$ $-0.05$ cdisc_data_accepts_TealDataset_TealDatasetConnector_TealDataConnector_objects
cdisc_data 💀 $0.01$ $-0.01$ cdisc_data_file_loads_the_TealData_object
cdisc_data 💀 $0.01$ $-0.01$ cdisc_data_file_uses_the_code_input_to_mutate_the_code_of_the_loaded_TealData_object
cdisc_data 💀 $0.01$ $-0.01$ cdisc_data_sets_primary_keys_as_join_keys_when_no_join_keys_are_present
cdisc_data 💀 $0.03$ $-0.03$ cdisc_data_sets_the_join_keys_internally
cdisc_data 💀 $0.03$ $-0.03$ cdisc_data_sets_the_join_keys_internally_based_on_parents_relations_when_primary_keys_are_altered
cdisc_data 💀 $0.01$ $-0.01$ cdisc_data_throws_error_when_a_parent_child_graph_is_not_correct
check_ellipsis 💀 $0.03$ $-0.03$ check_ellipsis_with_allowed_args
check_ellipsis 💀 $0.01$ $-0.01$ check_ellipsis_with_extra_named_and_unamed_arguments
check_ellipsis 💀 $0.01$ $-0.01$ check_ellipsis_with_extra_named_and_unamed_arguments_in_wrong_order
check_ellipsis 💀 $0.01$ $-0.01$ check_ellipsis_with_extra_named_arguments
check_ellipsis 💀 $0.01$ $-0.01$ check_ellipsis_with_extra_unamed_arguments
check_ellipsis 💀 $0.01$ $-0.01$ check_ellipsis_with_no_unused
data_label 💀 $0.08$ $-0.08$ get_cdisc_keys_returns_column_names_present_in_the_cached_datasets
get_code 💀 $0.01$ $-0.01$ Excludes_commented_keep_quoted_comments
get_code 💀 $0.02$ $-0.02$ Excludes_nocode_sigle_and_multi_line
get_code 💀 $0.01$ $-0.01$ Include_sourced_code
get_code 💀 $0.00$ $-0.00$ Reads_code_from_starts_at_to_stops_at
get_code 💀 $0.02$ $-0.02$ arguments_properly_specified
get_code 💀 $0.04$ $-0.04$ get_code.TealDataAbstract_returns_identical_code_to_TealDataAbstract_get_code
get_code 💀 $0.02$ $-0.02$ get_code.TealDatasetConnector_returns_identical_code_to_TealDatasetConnector_get_code
get_code 💀 $0.01$ $-0.01$ get_code.TealDataset_returns_identical_code_to_TealDataset_get_code
get_code_dataname 💀 $0.01$ $-0.01$ Excludes_commented_keep_quoted_comments
get_code_dataname 💀 $0.02$ $-0.02$ Excludes_nocode_sigle_and_multi_line
get_code_dataname 💀 $0.01$ $-0.01$ Include_sourced_code
get_code_dataname 💀 $0.01$ $-0.01$ NULL_empty
get_code_dataname 💀 $0.00$ $-0.00$ Reads_code_from_starts_at_to_stops_at
get_code_dataname 💀 $0.02$ $-0.02$ arguments_properly_specified
get_code_dataname 💀 $0.04$ $-0.04$ union_diff
get_join_keys 💀 $0.03$ $-0.03$ get_join_keys_is_deprecated
get_raw_data 💀 $0.02$ $-0.02$ get_raw_data.TealDataAbstract_returns_dataset_objects_verbatim_when_input_is_TealData
get_raw_data 💀 $0.04$ $-0.04$ get_raw_data.TealDataAbstract_returns_dataset_objects_verbatim_when_input_is_TealDataConnector_or_CDISCTealData
get_raw_data 💀 $0.01$ $-0.01$ get_raw_data.TealDatasetConnector_gives_warning_when_dataname_is_supplied_
get_raw_data 💀 $0.01$ $-0.01$ get_raw_data.TealDatasetConnector_returns_a_SCDA_data_frame_verbatim_
get_raw_data 💀 $0.00$ $-0.00$ get_raw_data.TealDataset_gives_warning_when_dataname_is_supplied_
get_raw_data 💀 $0.00$ $-0.00$ get_raw_data.TealDataset_returns_a_data.frame_verbatim_
get_raw_data 💀 $0.01$ $-0.01$ get_raw_data_validates_the_argument_dataname
is_pulled 💀 $0.01$ $-0.01$ Test_TealDataConnector_is_pulled
is_pulled 💀 $0.01$ $-0.01$ Test_TealDatasetConnector_is_pulled
is_pulled 💀 $0.01$ $-0.01$ Test_TealDataset_is_pulled
teal_data 💀 $0.01$ $-0.01$ empty_teal_data_returns_empty_code_id_wartnings_and_messages
teal_data 👶 $+0.01$ empty_teal_data_returns_empty_code_id_wartnings_and_messages_and_verified_TRUE
teal_data 👶 $+0.00$ non_empty_data_in_teal_data_returns_verified_FALSE
teal_data 💀 $0.02$ $-0.02$ teal_data_accepts_TealDataset_TealDatasetConnector_TealDataConnector_objects
teal_data 💀 $0.01$ $-0.01$ teal_data_file_loads_the_TealData_object
teal_data 💀 $0.01$ $-0.01$ teal_data_file_uses_the_code_input_to_mutate_the_code_of_the_loaded_TealData_object
teal_data 💀 $0.03$ $-0.03$ teal_data_returns_TealData_object_with_cdisc_dataset_input
teal_data 💀 $0.01$ $-0.01$ teal_data_sets_passed_join_keys_to_datasets_correctly
teal_data 💀 $0.01$ $-0.01$ teal_data_sets_passed_join_keys_to_datasets_correctly_when_key_names_differ
teal_data 💀 $0.01$ $-0.01$ teal_data_sets_passes_join_keys_to_datasets_correctly_when_key_names_differ_multiple_keys_
teal_data 💀 $0.01$ $-0.01$ update_join_keys_to_primary_updates_join_keys_with_character_0_when_no_primary_keys_exist
teal_data 💀 $0.01$ $-0.01$ update_join_keys_to_primary_updates_the_join_keys
teal_data 💀 $0.01$ $-0.01$ update_join_keys_to_primary_updates_the_join_keys_when_primary_keys_exist
to_relational_data 💀 $0.01$ $-0.01$ to_relational_data_accepts_TealDatasetConnector_as_input
to_relational_data 💀 $0.01$ $-0.01$ to_relational_data_accepts_TealDataset_CDISCTealDataset_as_input
to_relational_data 💀 $0.05$ $-0.05$ to_relational_data_accepts_a_MultiAssayExperiment_as_input
to_relational_data 💀 $0.01$ $-0.01$ to_relational_data_accepts_a_complete_named_list_of_data.frame_as_input
to_relational_data 💀 $0.01$ $-0.01$ to_relational_data_accepts_a_function_returning_a_TealDataset_as_input
to_relational_data 💀 $0.01$ $-0.01$ to_relational_data_accepts_a_function_returning_a_named_list_as_input
to_relational_data 💀 $0.05$ $-0.05$ to_relational_data_accepts_a_list_containing_a_named_MultiAssayExperiment_as_input
to_relational_data 💀 $0.01$ $-0.01$ to_relational_data_accepts_a_mixed_named_list_of_data.frame_as_input
to_relational_data 💀 $0.02$ $-0.02$ to_relational_data_accepts_a_mixed_named_list_of_objects_as_input
to_relational_data 💀 $0.01$ $-0.01$ to_relational_data_accepts_a_named_list_of_data.frame_as_input
to_relational_data 💀 $0.01$ $-0.01$ to_relational_data_accepts_an_unnamed_list_of_data.frame_as_input
to_relational_data 💀 $0.01$ $-0.01$ to_relational_data_accepts_cdisc_data.frame_as_input
to_relational_data 💀 $0.01$ $-0.01$ to_relational_data_accepts_data.frame_as_input
to_relational_data 💀 $0.02$ $-0.02$ to_relational_data_throws_error_with_a_function_returning_a_non_named_list
to_relational_data 💀 $0.01$ $-0.01$ to_relational_data_throws_error_with_a_function_returning_a_semi_named_list
to_relational_data 💀 $0.01$ $-0.01$ to_relational_data_throws_error_with_a_multiple_functions_returning_data.frame
utils 💀 $0.01$ $-0.01$ check_pkg_quietly_works
utils 💀 $0.03$ $-0.03$ get_key_duplicates_util_function
utils 💀 $0.03$ $-0.03$ get_teal_bs_theme
utils 💀 $0.01$ $-0.01$ validate_metadata_throws_error_if_metadata_is_not_a_list_of_length_one_atomics_or_NULL_
utils 💀 $0.01$ $-0.01$ validate_metadata_throws_error_if_metadata_is_not_a_list_or_NULL_
utils 💀 $0.01$ $-0.01$ validate_metadata_throws_error_if_metadata_is_not_a_named_list_or_NULL_
utils 💀 $0.00$ $-0.00$ validate_metadata_throws_no_error_if_metadata_is_NULL
verify 👶 $+0.01$ verify_raises_error_if_code_does_not_restore_objects_in_env
verify 👶 $+0.01$ verify_returns_error_for_qenv.error_input
verify 👶 $+0.01$ verify_returns_the_same_object_for_verified_TRUE
verify 👶 $+0.04$ verify_returns_the_same_object_with_changed_verified_field_for_properly_executed_code

Results for commit 4d679c9

♻️ This comment has been updated with latest results.

@vedhav
vedhav self-requested a review November 28, 2023 01:05
m7pr
m7pr reviewed Nov 28, 2023
View reviewed changes
Comment thread R/teal_data-get_code.R
vedhav
vedhav reviewed Nov 29, 2023
View reviewed changes
Comment thread R/teal_data-get_code.R Outdated
@kartikeyakirar @vedhav
Update R/teal_data-get_code.R
8937572 
Co-authored-by: Vedha Viyash <49812166+vedhav@users.noreply.github.com>
Signed-off-by: kartikeya kirar <kirar.kartikeya1@gmail.com>
@kartikeyakirar
kartikeyakirar merged commit 4c83688 into refactor Nov 29, 2023
@kartikeyakirar
kartikeyakirar deleted the 173_fix_get_code@refactor branch November 29, 2023 07:33
kartikeyakirar added a commit to insightsengineering/teal.code that referenced this pull request Nov 29, 2023
@kartikeyakirar @vedhav
get_code to return concatenated code string and removed `format_exp…
7ba7e80 
…ression` (#176)

this fixes #173


In this pull request, I've made updates to both the `get_code` and
`replace_code` methods. Now, when the `deparse `arg is set to TRUE,
these methods will return a concatenated string. Specifically, the
`get_code` method will return character(0) when used with `new_qenv(),`
provided no code has been set. As for `replace_code,` it will first
split the input string using "\n", then replace the last string in this
sequence. Finally, it concatenates these strings again before replacing
the code.

Removed `format_expression` function.

Example
```

q <- new_qenv()
get_code(q) # return character(0)
replace_code(q, "i <- iris")  # @code return character(0)

qq <- within(q, i <- iris)
qq <- within(qq, m <- mtcars)
get_code(qq) # return "i <- iris\nm <- mtcars"

replacement <- "i <- mtcars"
qr <- replace_code(qq, replacement)
get_code(qr) #return "i <- iris\ni <- mtcars"
```

Also review following modules for PR for changes.

- [ ] teal insightsengineering/teal#976
- [ ] teal.data
insightsengineering/teal.data#206
- [ ] teal.modules.general
insightsengineering/teal.modules.general#615
- [ ] teal.modules.clinical
insightsengineering/teal.modules.clinical#898
- [ ] teal.goshawk
insightsengineering/teal.goshawk#250
- [ ] teal.osprey
insightsengineering/teal.osprey#244

---------

Signed-off-by: kartikeya kirar <kirar.kartikeya1@gmail.com>
Co-authored-by: Vedha Viyash <49812166+vedhav@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m7pr m7pr m7pr left review comments
@vedhav vedhav vedhav approved these changes

Assignees

No one assigned

Labels

core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kartikeyakirar @vedhav @m7pr