193 bring get_code_dependency from teal.code - #194
Merged
Conversation
8 tasks
Contributor
|
Code Coverage SummaryDiff against mainResults for commit: 7265237 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Contributor
Contributor
Unit Test Performance Difference
Additional test case details
Results for commit 738c833 ♻️ This comment has been updated with latest results. |
chlebowa
approved these changes
Nov 21, 2023
m7pr
added a commit
that referenced
this pull request
Nov 24, 2023
Close #182 ### Feature description - Added `@verified` slot to `teal_data` class. - When object is initialized with empty `data` and `code` then `verified` is equal to `TRUE`. - If `data` or `code` are not-empty then `verified` is set to `FALSE`. - Introduced `verify` - S4 generic for `teal_data` and `qenv.error` classes. - Checks if you can reproduce `teal_data@env` with `teal_data@code`. - Sets `teal_data@verified` to TRUE if you can. - Throws an error other way. - For `qenv.error` throwns an error with `object@message` information. - Introduced `get_code` S4 generic for `teal_data` object - `datanames` parameter allows to use `get_code_dependency(code, names)` to get the code for specific objects. - `get_code_dependency` was moved from `teal.code` #194 - Introduced `show,teal_data-method` - adds message to the print for - `teal_data@verified = FALSE` saying object **is not** verified - `teal_data@verified = TRUE` saying object **is** verified ### Not included I did not provide a mechanism to block manual change of `@valid` slot, as we do not have this for `@code` / `@env` anyway. #### TODO - [x] add `get_code.teal_data()` S3 method - [x] rewrite `is_reproducible` to `S4 generic with method for teal_data and for qenv.error.` - [x] keep looking for a better name than `is_reproducible` #189 - [x] write `teal.data::get_code` S4 for `teal_data` object - [x] bring `get_code_dependency` from `teal.code` to `teal.data` #194 - [x] improve and simplify error statements #188 (comment) - [ ] fix documentation suggestions - [x] extend warnings for 3 scenarios of difference between code results and objects in `@env` --------- Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com> Signed-off-by: Pawel Rucki <12943682+pawelru@users.noreply.github.com> Signed-off-by: Aleksander Chlebowski <114988527+chlebowa@users.noreply.github.com> Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Aleksander Chlebowski <114988527+chlebowa@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Aleksander Chlebowski <aleksander.chlebowski@contractors.roche.com> Co-authored-by: André Veríssimo <211358+averissimo@users.noreply.github.com> Co-authored-by: Pawel Rucki <12943682+pawelru@users.noreply.github.com> Co-authored-by: pawelru <pawelru@users.noreply.github.com> Co-authored-by: go_gonzo <dawid.kaledkowski@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #193
Potentially improve with #192
Removal in
teal.codeinsightsengineering/teal.code#167