Set expectation when no code is used with qenv - #274
Merged
Conversation
Contributor
Code Coverage SummaryDiff against mainResults for commit: 71570f2 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Contributor
Unit Tests Summary 1 files 14 suites 6s ⏱️ Results for commit 71570f2. ♻️ This comment has been updated with latest results. |
Contributor
Unit Test Performance DifferenceAdditional test case details
Results for commit c5b25ea ♻️ This comment has been updated with latest results. |
osenan
approved these changes
Dec 5, 2025
osenan
left a comment
Contributor
There was a problem hiding this comment.
This is a very useful test. Good job!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Document expectation of what should return
qenvwith no code.Discovered while working on insightsengineering/teal#1630 where some code assumed it would return
NULL.Previously it was only tested that
testthat::expect_identical(get_code(qenv(), names = "a"), "").It makes sense that it also return
""when there is no code.