Improvements (i hope so) - #254
Merged
Merged
Conversation
gogonzo
commented
Jun 3, 2025
| #' q <- eval_code(q, expression(assert_number(a))) | ||
| #' | ||
| #' @aliases eval_code,qenv-method | ||
| #' @aliases eval_code,qenv.error-method |
Contributor
Author
There was a problem hiding this comment.
this is needed - all methods have to have own docs position
averissimo
reviewed
Jun 3, 2025
averissimo
left a comment
averissimo
left a comment
Contributor
There was a problem hiding this comment.
Awesome, I have one comment about passing the arguments forward
| @@ -48,20 +48,13 @@ | |||
| #' @export | |||
| #' | |||
| within.qenv <- function(data, expr, ...) { | |||
Contributor
There was a problem hiding this comment.
Should we check for named dots?
pkgload::load_all("teal.code")
#> ℹ Loading teal.code
qenv() |> within(aa <- 1+1, TRUE, FALSE)
#> <environment: 0x5b1c29313ae0> 🔒
#> Parent: <environment: devtools_shims>
#> Bindings:
#> - aa: [numeric]Created on 2025-06-03 with reprex v2.1.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code balance is + because I've added one test ;]