Change qenv as environment "type" -- adds names(qenv/qenv.error), get() and $ S3 methods

[averissimo]

Pull Request

• Part of [Feature Request]: Don't use @datanames anymore teal.data#333
• Fixes [Bug]: within doesn't keep integer type when using shorthand #221
• closes [Feature Request]: New $ method to access objs from env #164
• Companion of Adds names() function and deprecates datanames() teal.data#347

Changes description

• qenv S4 class inherits from environment data class
• Removes @env slot in favor of qenv
• Replace all instances of @env with @.xData (slot created by parent class)
• All functions/methods that work for environment class are supported natively in qenv

[github-actions]

Unit Tests Summary

  1 files   10 suites   1s ⏱️
124 tests 122 ✅ 2 💤 0 ❌
219 runs  217 ✅ 2 💤 0 ❌

Results for commit a5fcb9a.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
qenv-class	👶		$+0.25$	$+7$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
qenv-class	👶		$+0.10$	creates_a_locked_environment
qenv-class	👶		$+0.03$	creates_a_locked_environment_when_.xData_is_manually_defined
qenv-class	👶		$+0.01$	initialized_qenv_s_have_different_environments
qenv-class	👶		$+0.01$	throws_error_when_.xData_is_not_an_environment
qenv-class	👶		$+0.01$	throws_error_when_code_is_not_language_or_character_object
qenv-class	👶		$+0.11$	throws_error_when_id_and_code_length_doesn_t_match
qenv_constructor	👶		$+0.01$	does_not_allow_binding_to_be_added
qenv_constructor	👶		$+0.01$	does_not_allow_binding_to_be_modified
qenv_constructor	👶		$+0.02$	is_an_environment
qenv_constructor	👶		$+0.00$	ls_all.names_TRUE_show_all_objects
qenv_constructor	👶		$+0.00$	ls_does_not_show_hidden_objects
qenv_constructor	👶		$+0.00$	names_shows_available_objets
qenv_constructor	👶		$+0.00$	names_shows_hidden_objects
qenv_constructor	👶		$+0.00$	names_shows_nothing_on_empty_environment
qenv_constructor	💀	$0.01$	$-0.01$	parent_of_qenv_environment_is_locked
qenv_constructor	💀	$0.00$	$-0.00$	parent_of_qenv_environment_is_the_parent_of_.GlobalEnv
qenv_constructor	👶		$+0.00$	via_qenv_directly
qenv_constructor	👶		$+0.00$	via_slot
qenv_eval_code	💀	$0.01$	$-0.01$	env_in_qenv_is_always_a_sibling_of.GlobalEnv
qenv_get_code	💀	$0.01$	$-0.01$	works_for_datanames_of_length_1
qenv_get_code	👶		$+0.01$	works_for_names_of_length_1
qenv_get_var	👶		$+0.01$	get_var_and_only_returns_objects_from_qenv_not_.GlobalEnv
qenv_within	👶		$+0.00$	multiline_expressions_are_evaluated
qenv_within	👶		$+0.01$	within.qenv_renturns_a_qenv_where_.xData_is_a_deep_copy_of_that_in_data_
qenv_within	💀	$0.01$	$-0.01$	within.qenv_renturns_a_qenv_where_env_is_a_deep_copy_of_that_in_data_

Results for commit eecbc6d

♻️ This comment has been updated with latest results.

[github-actions]

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  ---------
R/qenv-c.R                          57       2  96.49%   75, 106
R/qenv-class.R                      19       2  89.47%   42, 45
R/qenv-concat.R                     10       0  100.00%
R/qenv-constructor.R                 1       0  100.00%
R/qenv-errors.R                      4       4  0.00%    6-9
R/qenv-eval_code.R                  52       2  96.15%   99, 108
R/qenv-get_code.R                   28       0  100.00%
R/qenv-get_env.R                     3       3  0.00%    22-27
R/qenv-get_var.R                    27       0  100.00%
R/qenv-get_warnings.R               24       0  100.00%
R/qenv-join.R                        7       0  100.00%
R/qenv-length.R                      2       0  100.00%
R/qenv-show.R                        1       1  0.00%    19
R/qenv-within.R                      8       0  100.00%
R/utils-get_code_dependency.R      191       1  99.48%   283
R/utils.R                            9       0  100.00%
TOTAL                              443      15  96.61%

Diff against main

Filename                Stmts    Miss  Cover
--------------------  -------  ------  --------
R/qenv-c.R                +57      +2  +96.49%
R/qenv-class.R            +19      +2  +89.47%
R/qenv-constructor.R      -15     -13  +81.25%
R/qenv-errors.R            +4      +4  +100.00%
R/qenv-get_var.R           +8       0  +100.00%
R/qenv-join.R             -39       0  +100.00%
R/qenv-length.R            +2       0  +100.00%
R/utils.R                  -1       0  +100.00%
TOTAL                     +35      -5  +1.52%

Results for commit: a5fcb9a

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[gogonzo]

Please test cover new functions

[averissimo]

Some topics to discuss on this implementation

[gogonzo]

👍