Skip to content

Removing old rd syntax - #191

Merged
kartikeyakirar merged 6 commits into
mainfrom
old_rd_syntax@main
Jan 10, 2024
Merged

Removing old rd syntax#191
kartikeyakirar merged 6 commits into
mainfrom
old_rd_syntax@main

Conversation

@kartikeyakirar

Copy link
Copy Markdown
Contributor

this is part of #189

I noticed some old syntax that was not previously checked, so I am creating a separate pull request for it.

@github-actions

github-actions Bot commented Jan 10, 2024

Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ---------
R/qenv-concat.R             10       0  100.00%
R/qenv-constructor.R        16      13  18.75%   54-93
R/qenv-eval_code.R          52       2  96.15%   100, 109
R/qenv-get_code.R           20       1  95.00%   38
R/qenv-get_env.R             3       3  0.00%    23-31
R/qenv-get_var.R            19       0  100.00%
R/qenv-get_warnings.R       24       0  100.00%
R/qenv-join.R               46       0  100.00%
R/qenv-show.R                1       1  0.00%    19
R/qenv-within.R              8       0  100.00%
R/utils.R                   10       0  100.00%
TOTAL                      209      20  90.43%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: a462844

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions

github-actions Bot commented Jan 10, 2024

Copy link
Copy Markdown
Contributor

Unit Tests Summary

  1 files    9 suites   0s ⏱️
 62 tests  62 ✅ 0 💤 0 ❌
134 runs  134 ✅ 0 💤 0 ❌

Results for commit a462844.

♻️ This comment has been updated with latest results.

@donyunardi donyunardi mentioned this pull request Jan 10, 2024
33 tasks
@kartikeyakirar
kartikeyakirar enabled auto-merge (squash) January 10, 2024 17:45

@averissimo averissimo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Minor comments related to \cr.

  • One \cr is being displayed in the man page. Please remove this.
  • Consider replacing other \cr with markdown's 2 new lines, but very optional.

(Didn't mark as approved as auto-merge is on and documentation needs to be re-generated if suggestions are integrated)

Comment thread R/qenv-join.R Outdated
Comment thread R/qenv-join.R Outdated
Comment thread R/qenv-join.R Outdated
Comment thread R/qenv-join.R Outdated
kartikeyakirar and others added 4 commits January 10, 2024 23:58
Co-authored-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
Signed-off-by: kartikeya kirar <kirar.kartikeya1@gmail.com>
Comment thread R/qenv-join.R Outdated
Comment thread R/qenv-join.R Outdated

@donyunardi donyunardi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@kartikeyakirar
kartikeyakirar merged commit d16ddd7 into main Jan 10, 2024
@kartikeyakirar
kartikeyakirar deleted the old_rd_syntax@main branch January 10, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants