Skip to content

168 extend get_code with ... - #169

Merged
m7pr merged 8 commits into
mainfrom
182_validate_teal_data@main
Nov 22, 2023
Merged

168 extend get_code with ...#169
m7pr merged 8 commits into
mainfrom
182_validate_teal_data@main

Conversation

@m7pr

@m7pr m7pr commented Nov 22, 2023

Copy link
Copy Markdown
Contributor

Close #168
Needed for insightsengineering/teal.data#188 and potential other future methods that will have more parameters than current default S4 generic of get_code.

@m7pr m7pr added the core label Nov 22, 2023
@m7pr
m7pr requested a review from chlebowa November 22, 2023 09:46
@github-actions

github-actions Bot commented Nov 22, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ---------
R/include_css_js.R           7       7  0.00%    12-20
R/qenv-concat.R             10       0  100.00%
R/qenv-constructor.R        12       0  100.00%
R/qenv-eval_code.R          52       2  96.15%   100, 109
R/qenv-get_code.R           18       0  100.00%
R/qenv-get_var.R            19       0  100.00%
R/qenv-get_warnings.R       24       0  100.00%
R/qenv-join.R               46       0  100.00%
R/qenv-replace_code.R        8       0  100.00%
R/qenv-show.R                1       1  0.00%    16
R/qenv-within.R              7       0  100.00%
R/utils.R                   12       0  100.00%
TOTAL                      216      10  95.37%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: f10f5a0

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions

github-actions Bot commented Nov 22, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Unit Tests Summary

    1 files    10 suites   0s ⏱️
  75 tests   75 ✔️ 0 💤 0 ❌
161 runs  161 ✔️ 0 💤 0 ❌

Results for commit f10f5a0.

♻️ This comment has been updated with latest results.

chlebowa
chlebowa approved these changes Nov 22, 2023
View reviewed changes

@chlebowa chlebowa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny reword.

Comment thread R/qenv-get_code.R Outdated
@m7pr m7pr mentioned this pull request Nov 22, 2023
Merged
8 tasks
m7pr and others added 3 commits November 22, 2023 12:54
@m7pr @chlebowa
Update R/qenv-get_code.R
77bd761 
Co-authored-by: Aleksander Chlebowski <114988527+chlebowa@users.noreply.github.com>
Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
@dependabot-preview
[skip actions] Roxygen Man Pages Auto Update
0952e7f
@m7pr
Empty-Commit
63875e7
@m7pr
m7pr enabled auto-merge (squash) November 22, 2023 11:58
@m7pr
m7pr merged commit 5850a05 into main Nov 22, 2023
@m7pr
m7pr deleted the 182_validate_teal_data@main branch November 22, 2023 13:01
@m7pr m7pr mentioned this pull request Nov 28, 2023
Merged
donyunardi pushed a commit that referenced this pull request Nov 28, 2023
@m7pr
Add ... to get_code.qenv.error (#177)
8a650da 
Similarly to #168 and #169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@chlebowa chlebowa chlebowa approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Extend get_code with ...

2 participants

@m7pr @chlebowa