Skip to content

remove replace_code function - #163

Merged
chlebowa merged 4 commits into
mainfrom
remove_replace_code@main
Dec 14, 2023
Merged

remove replace_code function#163
chlebowa merged 4 commits into
mainfrom
remove_replace_code@main

Conversation

@chlebowa

Copy link
Copy Markdown
Contributor

Rolls back #160

@chlebowa chlebowa added the core label Nov 10, 2023
@chlebowa
chlebowa requested a review from gogonzo November 13, 2023 19:38
@chlebowa
chlebowa marked this pull request as ready for review November 13, 2023 19:38
@github-actions

github-actions Bot commented Nov 13, 2023

Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ---------
R/qenv-concat.R             10       0  100.00%
R/qenv-constructor.R        16      13  18.75%   54-93
R/qenv-eval_code.R          52       2  96.15%   100, 109
R/qenv-get_code.R           20       1  95.00%   38
R/qenv-get_var.R            19       0  100.00%
R/qenv-get_warnings.R       24       0  100.00%
R/qenv-join.R               46       0  100.00%
R/qenv-show.R                1       1  0.00%    19
R/qenv-within.R              8       0  100.00%
R/utils.R                   10       0  100.00%
TOTAL                      206      17  91.75%

Diff against main

Filename             Stmts    Miss  Cover
-----------------  -------  ------  -------
R/qenv-get_code.R        0      +1  -5.00%
TOTAL                    0      +1  -0.85%

Results for commit: 3aa400a

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions

github-actions Bot commented Nov 13, 2023

Copy link
Copy Markdown
Contributor

Unit Tests Summary

    1 files      9 suites   0s ⏱️
  62 tests   62 ✔️ 0 💤 0
134 runs  134 ✔️ 0 💤 0

Results for commit 3aa400a.

♻️ This comment has been updated with latest results.

@donyunardi donyunardi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gogonzo gogonzo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait. I have not fixed connectors to use wrappers

@chlebowa

Copy link
Copy Markdown
Contributor Author

Please wait. I have not fixed connectors to use wrappers

No problem, let me know when you're ready.

@chlebowa chlebowa added blocked and removed blocked labels Nov 14, 2023
@chlebowa
chlebowa marked this pull request as draft November 20, 2023 12:38
@averissimo

Copy link
Copy Markdown
Contributor

The connectors have been updated, is this still blocked?

@chlebowa

Copy link
Copy Markdown
Contributor Author

If replace_code is never used anymore, we can proceed. Please confirm and I will refresh the branch.

@gogonzo
gogonzo dismissed their stale review December 13, 2023 12:55

not relevant anymore

@gogonzo

gogonzo commented Dec 13, 2023

Copy link
Copy Markdown
Contributor

@chlebowa please proceed. Please bear in mind that we will have to present connectors to snowflake team and they will be put in the situation where they don't have any alternative but use a custom-connection-function (connection opener + module).

@chlebowa
chlebowa marked this pull request as ready for review December 13, 2023 13:26
@chlebowa chlebowa removed the blocked label Dec 13, 2023
@github-actions

github-actions Bot commented Dec 13, 2023

Copy link
Copy Markdown
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
qenv-replace_code 💀 $0.15$ $-0.15$ $-7$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
qenv-replace_code 💀 $0.01$ $-0.01$ code_argument_accepts_character
qenv-replace_code 💀 $0.00$ $-0.00$ code_argument_accepts_expression
qenv-replace_code 💀 $0.00$ $-0.00$ code_argument_accepts_language
qenv-replace_code 💀 $0.00$ $-0.00$ code_replace_replaces_last_element_of_the_code
qenv-replace_code 💀 $0.00$ $-0.00$ no_changes_are_made_to_empty_code_slot
qenv-replace_code 💀 $0.05$ $-0.05$ object_argument_accepts_qenv
qenv-replace_code 💀 $0.07$ $-0.07$ object_argument_accepts_qenv.error

Results for commit 94fc547

♻️ This comment has been updated with latest results.

@chlebowa
chlebowa enabled auto-merge (squash) December 14, 2023 12:01
@chlebowa
chlebowa merged commit 3d4fd3c into main Dec 14, 2023
@chlebowa
chlebowa deleted the remove_replace_code@main branch December 14, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants