Skip to content

Introduce teal_data class - #153

Merged
gogonzo merged 5 commits into
mainfrom
teal_data@main
Oct 18, 2023
Merged

Introduce teal_data class#153
gogonzo merged 5 commits into
mainfrom
teal_data@main

Conversation

@gogonzo

@gogonzo gogonzo commented Oct 6, 2023

Copy link
Copy Markdown
Contributor

Necessary fixes
@github-actions

github-actions Bot commented Oct 6, 2023

Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ------------------------
R/include_css_js.R               7       7  0.00%    12-20
R/qenv-concat.R                 10       0  100.00%
R/qenv-constructor.R            12       0  100.00%
R/qenv-eval_code.R              49       2  95.92%   95, 104
R/qenv-get_code.R               18       0  100.00%
R/qenv-get_var.R                19       0  100.00%
R/qenv-get_warnings.R           24       0  100.00%
R/qenv-join.R                   46       0  100.00%
R/qenv-show.R                    1       1  0.00%    16
R/qenv-within.R                  7       0  100.00%
R/utils-code_dependency.R      190       7  96.32%   37, 42, 252-253, 317-320
R/utils.R                       12       0  100.00%
TOTAL                          395      17  95.70%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 6806394

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions

github-actions Bot commented Oct 6, 2023

Copy link
Copy Markdown
Contributor

Unit Tests Summary

    1 files    10 suites   1s ⏱️
  92 tests   92 ✔️ 0 💤 0
186 runs  186 ✔️ 0 💤 0

Results for commit 6806394.

♻️ This comment has been updated with latest results.

@pawelru

pawelru commented Oct 10, 2023

Copy link
Copy Markdown
Contributor

Please add NEWS

update NEWS
replacing exportMethod with export - same effect
revert to initial
@vedhav
vedhav self-requested a review October 18, 2023 12:09

@vedhav vedhav left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gogonzo
gogonzo merged commit 4eebc84 into main Oct 18, 2023
@gogonzo
gogonzo deleted the teal_data@main branch October 18, 2023 12:11
@chlebowa

Copy link
Copy Markdown
Contributor

methods::new is no longer needed then, is it?

@gogonzo

gogonzo commented Oct 18, 2023

Copy link
Copy Markdown
Contributor Author

methods::new is no longer needed then, is it?
True. Not needed, but not suggested to do otherwise neither

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants