#133 code parser alternative

[m7pr]

Fixes #133

Alternative to #139

[gogonzo]

Looks like format_expression doesn't make sense anymore. We rather need style_string_code instead.

[m7pr]

Hey @gogonzo this isn't working at all, I just pushed the code at the end of the day so it's secured by being send to a remote repository. It should be ready for testing today at the end of the day

[m7pr]

Hey @gogonzo and @chlebowa, an update for you!
I managed to rewrite code parser so it works on characters.
There are 2 more tests that I'd like to fix

• https://github.com/insightsengineering/teal.code/pull/146/files#diff-229b1e27e5ba810950a45cb94c022b17e78cb0ea267032220ee5bf819474fef8R117
• https://github.com/insightsengineering/teal.code/pull/146/files#diff-229b1e27e5ba810950a45cb94c022b17e78cb0ea267032220ee5bf819474fef8R219

And I'd like to incorporate few more feedback points from the other PR

• 133 code parser #139 (comment)
• 133 code parser #139 (comment)
• 133 code parser #139 (comment)

[chlebowa]

I move that

1. Only the generic constructor is mentioned in usage.
   
2. new_qenv, eval_code be documented in one file. Perhaps get_code as well.

---

Also, since we do require the user to tag code lines, I wonder whether we should extend it to have them tag all lines and not try to find dependencies automatically.

Then we could simply

cc <- c("sp <- 'virginica' #@effect ii", "i <- iris #@effect ii", "ii <- subset(i, Species == sp) #@effect ii")
ex <- parse(text = cc)
lines <- attr(ex, "srcfile")$lines
# pseudo
l <- grep("@effect ii", lines, value = TRUE)

[gogonzo]

This fails

  q <- new_qenv()
  q <- eval_code(q, expression({
    a <- 1
    b <- 2
  }))  

  testthat::expect_identical(
    get_code(q, names = "a"),
    "a <- 1"
  )

I think curly brackets should be removed either before inserting code to @code. Thanks to this trace in qenv.error will have no brackets also.

[chlebowa]

It seems a list containing a symbol cannot be unlisted 🤔

[m7pr]

Will have a look @chlebowa . You are good to go!

[chlebowa]

I adapted lang2calls slightly and now everything works consistently.

[m7pr]

Hey, we had a debate with @gogonzo on the final form of the current stage of code parser.
We decided to leave get_dependency_code the way it is as an unexported function.
We only changed the format of eval_code so it returns characters so in the future we can apply get_dependency_code on it. There are potential ideas on the simplification of get_dependency_code implementation, but those are minor and can be addressed in the future.

@gogonzo would you mind taking a final look at the commit with recent changes that we discussed 193a52e
?

[gogonzo]

code_dependency covers cases which we desperately needed in teal. I accept this solution which can be now implemented on the refactor branch, where we can detect edge cases. Please merge to main once GH checks pass

[m7pr]

Amazing, created a card for potential minor improvements that we can provide in the future #154

[github-actions]

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ------------------------
R/include_css_js.R               7       7  0.00%    12-20
R/qenv-concat.R                 10       0  100.00%
R/qenv-constructor.R            12       0  100.00%
R/qenv-eval_code.R              49       2  95.92%   95, 104
R/qenv-get_code.R               18       0  100.00%
R/qenv-get_var.R                19       0  100.00%
R/qenv-get_warnings.R           24       0  100.00%
R/qenv-join.R                   46       0  100.00%
R/qenv-show.R                    1       1  0.00%    16
R/qenv-within.R                  7       0  100.00%
R/utils-code_dependency.R      190       7  96.32%   37, 42, 252-253, 317-320
R/utils.R                       12       0  100.00%
TOTAL                          395      17  95.70%

Diff against main

Filename                     Stmts    Miss  Cover
-------------------------  -------  ------  --------
R/qenv-eval_code.R              +1       0  +0.09%
R/utils-code_dependency.R     +190      +7  +96.32%
R/utils.R                       -7       0  +100.00%
TOTAL                         +184      +7  +0.44%

Results for commit: 864cc52

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results