Skip to content

Clean up (re-document, fix linters, update old magritr to native pipe) #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Melkiades merged 8 commits into from
Jul 2, 2026
Merged

Clean up (re-document, fix linters, update old magritr to native pipe) #1099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
95b055f
update: update old magritrr to native pipe
munoztd0 Jul 1, 2026
92b289f
linting: fix lints
munoztd0 Jul 1, 2026
264a1c7
document: runnned document with roxygen2 version 8.0.0 and all CRAN u…
munoztd0 Jul 1, 2026
288efba
add myself as contributor
munoztd0 Jul 1, 2026
d717b6f
refactor: update to native pipe
munoztd0 Jul 1, 2026
1474cd9
fix: document
munoztd0 Jul 2, 2026
05bf44a
Update WORDLIST
munoztd0 Jul 2, 2026
067be01
Update WORDLIST
munoztd0 Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ repos:
- id: roxygenize
additional_dependencies:
- insightsengineering/formatters
- magrittr
- methods
- checkmate
- htmltools
Expand Down
4 changes: 2 additions & 2 deletions DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ Authors@R: c(
comment = c(ORCID = "0009-0005-2083-1105")),
person("Joe", "Zhu", , "joe.zhu@roche.com", role = c("aut", "cre"),
comment = c(ORCID = "0000-0001-7566-2787")),
person("David", "Munoz Tord", , "david.munoztord@mailbox.org", role = "ctb"),
person("F. Hoffmann-La Roche AG", role = c("cph", "fnd"))
)
Description: Reporting tables often have structure that goes beyond simple
Expand All @@ -34,7 +35,6 @@ URL: https://github.com/insightsengineering/rtables,
BugReports: https://github.com/insightsengineering/rtables/issues
Depends:
formatters (>= 0.5.12),
magrittr (>= 2.0.3),
methods,
R (>= 4.1)
Imports:
Expand All @@ -61,7 +61,7 @@ VignetteBuilder:
knitr,
rmarkdown
Config/Needs/verdepcheck: insightsengineering/formatters,
tidyverse/magrittr, mllg/checkmate, rstudio/htmltools,
mllg/checkmate, rstudio/htmltools,
gagolews/stringi, tidymodels/broom, cran/car, tidyverse/dplyr,
davidgohel/flextable, yihui/knitr, r-lib/lifecycle,
davidgohel/officer, Merck/r2rtf, rstudio/rmarkdown, therneau/survival,
Expand Down
6 changes: 0 additions & 6 deletions NAMESPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,15 +318,9 @@ import(methods)
importFrom(formatters,do_forced_paginate)
importFrom(formatters,export_as_pdf)
importFrom(formatters,export_as_txt)
importFrom(htmltools,tagList)
importFrom(htmltools,tags)
importFrom(lifecycle,deprecated)
importFrom(magrittr,"%>%")
importFrom(stats,binom.test)
importFrom(stats,na.omit)
importFrom(stats,prop.test)
importFrom(stats,quantile)
importFrom(stats,relevel)
importFrom(stats,setNames)
importFrom(tools,file_ext)
importFrom(utils,browseURL)
Expand Down
4 changes: 2 additions & 2 deletions R/Viewer.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ NULL
#'
#' df <- cbind(iris, sl5 = sl5)
#'
#' lyt <- basic_table() %>%
#' split_cols_by("sl5") %>%
#' lyt <- basic_table() |>
#' split_cols_by("sl5") |>
#' analyze("Sepal.Length")
#'
#' tbl <- build_table(lyt, df)
Expand Down
Loading
Loading