Update gcp_checks.py#53
Merged
Merged
Conversation
Google Cloud Functions check did not correctly compile the candidates list; each instance of region from the respective config file list would overwrite the last, so only the last region listed was being used. Fix initializes candidates list and changes the replace to an append.
Owner
|
Oh wow, nice catch!!! Thanks so much for taking the time to submit this fix. :) |
Owner
|
Hi @davidmcduffie, There was a previous plan to move this project from GPL to MIT license, discussed here: #50 I just went ahead and did it, but I realize technically your contribution was to a GPL project. Are you ok with this license change? It affects the PR you submitted, meaning your code will be MIT and not GPL. I just want to make sure you are cool with that. If not, I understand - just let me know and I will figure out a compliant way to include your fix. Thanks! |
Contributor
Author
|
No issues at all with the license change @initstring, thanks for the heads up and for making this neat tool. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google Cloud Functions check did not correctly compile the candidates list; each instance of region from the respective config file list would overwrite the last, so only the last region listed was being used. Fix initializes candidates list and changes the replace to an append.