Skip to content

Refactor Axios request#5

Merged
JeffLoucks merged 1 commit into
masterfrom
hotfix/debug-request
Jan 7, 2025
Merged

Refactor Axios request#5
JeffLoucks merged 1 commit into
masterfrom
hotfix/debug-request

Conversation

@JeffLoucks

Copy link
Copy Markdown
  • Mailchimp requests are failing in dracula and I traced it back to requests not being fulfilled in this library
  • It looks like when this was refactored from using the deprecated request library that it was still using the same arguments for request and not axios. request takes a config and a call back and looks like this:

request(config, function(resp, err) {
  // handle resp or error in callback
})

While axios looks like this:

axios(config)
  .then((resp) => //handle resp)
  .catch((err) => //handle err)

So, this PR is my attempt to use axios as their docs intend to see if it resolves some of our mailchimp issues.

@krcummings1 krcummings1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for finding and fixing this!

@JeffLoucks JeffLoucks merged commit 220c60c into master Jan 7, 2025
@JeffLoucks JeffLoucks deleted the hotfix/debug-request branch January 7, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants