chore(inputs.kinesis_consumer): Replace consumer library by own implementation#16332
Merged
Conversation
1 task
3027f70 to
6600f16
Compare
1 task
Contributor
|
@srebhan Could you rebase this PR? |
mstrandboge
approved these changes
Mar 3, 2025
6600f16 to
66a8ffd
Compare
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
|
@srebhan This PR appears to have introduced an issue with the Kinesis consumer, at least in our environment. It operates correctly with Kinesis streams that have a relatively small number of shards but stops consuming messages when the shard count reaches approximately 20 or more. No errors are reported — the consumer simply stops receiving data. The last known working version of Telegraf is v1.33.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The current implementation of the kinesis consumer relies on the
github.com/harlow/kinesis-consumerlibrary. This library seems not to be maintained anymore. Furthermore, the mentioned library does not harmonize well with Telegraf when it comes to storing shard iterators in a DynamoDB as Telegraf wants the iterators to represent the latest metric delivered and the library wants to store the last record consumed.To overcome these issues and to reduce the number of reads from the DynamoDB in case it is configured this PR implements the consumer itself and now only relies on the AWS Golang SDK v2.
This PR has been tested in a toy scenario including
max_undelivered_messages.When enabling the tracing log-level for this plugin, details on the consumption process are logged.
Checklist
Related issues