feat: Optionally preserve proto field names#76
Merged
kodiakhq[bot] merged 2 commits intoinfluxdata:mainfrom Oct 26, 2022
Merged
feat: Optionally preserve proto field names#76kodiakhq[bot] merged 2 commits intoinfluxdata:mainfrom
kodiakhq[bot] merged 2 commits intoinfluxdata:mainfrom
Conversation
This change adds a flag to the code-gen builder, allowing output json fields to use their proto-schema defined field names instead of being converted to lowerCamelCase. Preserving proto field names is mentioned as an optional feature in the protobuf json specification[1]. This change builds on the previous support[2] for deserializing preserved proto field names. [1]: https://developers.google.com/protocol-buffers/docs/proto3#json_options [2]: influxdata#72
tustvold
approved these changes
Oct 26, 2022
Contributor
tustvold
left a comment
tustvold
left a comment
There was a problem hiding this comment.
Sorry for taking so long to get to this, looks good to me. Took the liberty of updating the CI
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a flag to the code-gen builder, allowing output json
fields to use their proto-schema defined field names instead of being
converted to lowerCamelCase.
Preserving proto field names is mentioned as an optional feature in the
protobuf json specification1. This change builds on the previous
support2 for deserializing preserved proto field names.