✨ feat: add delete-email command#108
Conversation
There was a problem hiding this comment.
Code Review
This pull request implements a new delete-email command, enabling users to soft-delete received emails via the CLI. The changes include documentation updates, the addition of the DeleteEmail command variant, interactive confirmation logic with a --force flag, and human-readable output formatting for the deletion result. Feedback was provided regarding the unit tests, specifically noting that several assertions lack descriptive messages, which is a violation of the repository's coding standards (Rule 74).
There was a problem hiding this comment.
Pull request overview
Adds a new delete-email CLI subcommand that calls the MCP delete_email tool to soft-delete (hide) a received email by message ID, including a safety confirmation flow with --force bypass, plus human-readable output formatting and documentation updates.
Changes:
- Introduce
delete-emailcommand with--forceand a TTY-only confirmation prompt. - Add human-readable output formatting for
delete_emailresults and update built-in CLI help text/examples. - Add focused unit tests for argument parsing, human output formatting, and help text inclusion.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/main.rs |
Adds the new DeleteEmail clap command, confirmation guard, MCP call wiring, human output formatting, and related tests/help text. |
README.md |
Documents the new delete-email CLI subcommand and examples. |
docs/help.md |
Adds delete_email to the tool list and documents soft-delete behavior with CLI examples. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@vish-dini please validate and merge this PR when it is ready. This adds the CLI delete-email command and confirmation flow. |
|
Second nightly pass (2026-05-08 UTC): rechecked latest head + thread state. All review threads are resolved, CI is green, and no new actionable deltas surfaced. Next concrete step: maintainer human review + merge; if new feedback lands, I’ll pick it up on latest head. |
Summary
inboxapi delete-email <message-id>with confirmation and--forceTesting
cargo test delete_email -- --nocapturegit diff --check