Skip to content

✨ feat: add delete-email command#108

Merged
shaond merged 4 commits into
mainfrom
inboxapi-mcp-saf
May 8, 2026
Merged

✨ feat: add delete-email command#108
shaond merged 4 commits into
mainfrom
inboxapi-mcp-saf

Conversation

@shaond
Copy link
Copy Markdown
Collaborator

@shaond shaond commented May 8, 2026

Summary

  • add inboxapi delete-email <message-id> with confirmation and --force
  • add human-readable delete output and CLI help/docs updates
  • cover the new command with focused CLI tests

Testing

  • cargo test delete_email -- --nocapture
  • git diff --check

Copilot AI review requested due to automatic review settings May 8, 2026 05:36
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements a new delete-email command, enabling users to soft-delete received emails via the CLI. The changes include documentation updates, the addition of the DeleteEmail command variant, interactive confirmation logic with a --force flag, and human-readable output formatting for the deletion result. Feedback was provided regarding the unit tests, specifically noting that several assertions lack descriptive messages, which is a violation of the repository's coding standards (Rule 74).

Comment thread src/main.rs Outdated
Comment thread src/main.rs Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new delete-email CLI subcommand that calls the MCP delete_email tool to soft-delete (hide) a received email by message ID, including a safety confirmation flow with --force bypass, plus human-readable output formatting and documentation updates.

Changes:

  • Introduce delete-email command with --force and a TTY-only confirmation prompt.
  • Add human-readable output formatting for delete_email results and update built-in CLI help text/examples.
  • Add focused unit tests for argument parsing, human output formatting, and help text inclusion.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/main.rs Adds the new DeleteEmail clap command, confirmation guard, MCP call wiring, human output formatting, and related tests/help text.
README.md Documents the new delete-email CLI subcommand and examples.
docs/help.md Adds delete_email to the tool list and documents soft-delete behavior with CLI examples.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md
Comment thread docs/help.md
Copilot AI review requested due to automatic review settings May 8, 2026 05:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comment thread src/main.rs Outdated
Comment thread README.md Outdated
@shaond
Copy link
Copy Markdown
Collaborator Author

shaond commented May 8, 2026

@vish-dini please validate and merge this PR when it is ready. This adds the CLI delete-email command and confirmation flow.

@shaond shaond merged commit f2af7dc into main May 8, 2026
2 checks passed
@shaond shaond deleted the inboxapi-mcp-saf branch May 8, 2026 07:13
@sara-dini
Copy link
Copy Markdown
Collaborator

Second nightly pass (2026-05-08 UTC): rechecked latest head + thread state. All review threads are resolved, CI is green, and no new actionable deltas surfaced. Next concrete step: maintainer human review + merge; if new feedback lands, I’ll pick it up on latest head.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants