fix: retry on GOAWAY errors when using cached HTTP/2 connections#491
Open
0xuLiang wants to merge 1 commit intoimroc:masterfrom
Open
fix: retry on GOAWAY errors when using cached HTTP/2 connections#4910xuLiang wants to merge 1 commit intoimroc:masterfrom
0xuLiang wants to merge 1 commit intoimroc:masterfrom
Conversation
RoundTripOnlyCachedConn bypasses the retry loop in RoundTripOpt, so GOAWAY and other retryable errors were returned directly to callers. Now we check CanRetryError before returning, allowing retryable errors to fall through and create a new connection. Changes: - Export canRetryError as CanRetryError - Check CanRetryError in roundTrip when RoundTripOnlyCachedConn fails
|
I could not wait for a tagged release. If you need a release with the above fix you can get it from github.com/bertold/req v3.57.2 - note that this repo is a hard fork. |
Author
I checked in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RoundTripOnlyCachedConn bypasses the retry loop in RoundTripOpt, so GOAWAY and other retryable errors were returned directly to callers.
Now we check CanRetryError before returning, allowing retryable errors to fall through and create a new connection.
Changes:
Fixes #376