Remove content-length header - #385
Merged
Merged
Conversation
Contributor
|
Thanks for this contribution! Is there a specific issue this fixes? This seems to be the rationale: Is there an envoy issue related to this? |
johanbrandhorst
self-requested a review
April 11, 2019 10:05
johanbrandhorst
approved these changes
Apr 11, 2019
Contributor
Author
|
Contributor
|
OK, so the issue is if we have a daisy chain of proxies where this proxy will transform a HTTP/1.1 request to HTTP/2 but not remove the Thanks! |
Contributor
|
I'll merge as soon as travis has succeeded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Move the patch from envoy proxy.
https://sourcegraph.com/github.com/envoyproxy/envoy@cfc514546bc0284536893cca5fa43d7128edcd35/-/blob/source/extensions/filters/http/grpc_web/grpc_web_filter.cc#L51
Verification
I tried the patch locally and check the content-length has been removed.