[minor] fix: recursive issue with Draft and JSONTypes#990
Merged
mweststrate merged 1 commit intoimmerjs:masterfrom Jan 15, 2023
Merged
[minor] fix: recursive issue with Draft and JSONTypes#990mweststrate merged 1 commit intoimmerjs:masterfrom
mweststrate merged 1 commit intoimmerjs:masterfrom
Conversation
✅ Deploy Preview for quizzical-lovelace-dcbd6a canceled.
|
mweststrate
approved these changes
Jan 15, 2023
Collaborator
mweststrate
left a comment
There was a problem hiding this comment.
Looking good, will merge!
|
Nice work! Thank you! |
Contributor
|
🎉 This PR is included in version 9.0.18 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
@mweststrate This PR does not properly fix the issue and introduces bugs in other scenarios (#1013). It should probably be reverted. |
Methuselah96
added a commit
to Methuselah96/immer
that referenced
this pull request
Jan 16, 2023
Methuselah96
added a commit
to Methuselah96/immer
that referenced
this pull request
Jan 16, 2023
mweststrate
pushed a commit
that referenced
this pull request
Jan 16, 2023
* Add failing test * Revert #990
Collaborator
Contributor
Author
|
Thanks for reverting. The fix didn't take account for union type. Will see if I can make a proper fix for that later. Can we reopen #839? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #839
I have added test under
__tests__/types/type-externals.ts.There are several things I have observed:
yarn build -> 'cp' is not recognized as an internal or external commandI think these should be fixed.
Here is an video about the details: https://www.youtube.com/watch?v=PCRzWIubAEQ