fix: Mark exports as pure, for better tree-shakability#1124
Merged
mweststrate merged 1 commit intoimmerjs:mainfrom Sep 1, 2025
Merged
Conversation
mweststrate
approved these changes
Sep 1, 2025
Collaborator
mweststrate
left a comment
There was a problem hiding this comment.
Thanks for catching this!
Contributor
|
🎉 This PR is included in version 10.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider an application that uses only
producebut no other methods. This PR allows such an application to be properly tree-shaken by a bundler, to eliminate the other exports altogether.Bundle
pnpm dlx esbuild --bundle --define:process.env.NODE_ENV='"production"' --tree-shaking index.tsDiff as compared to the version on
main