Open
Conversation
supun-io
force-pushed
the
create-subscribers-endpoint
branch
from
d9ce666 to
bb195f1
Compare
Member
Author
|
@Nadil-K need a careful review of the POST /subscribers endpoint, and the used services and the listeners (ConfirmationMailListener, ListRemovalListener). |
supun-io
force-pushed
the
create-subscribers-endpoint
branch
from
a8745f7 to
d31e097
Compare
supun-io
force-pushed
the
create-subscribers-endpoint
branch
from
4880abb to
4185e5c
Compare
Nadil-K
reviewed
Apr 28, 2026
Member
Nadil-K
left a comment
Nadil-K
left a comment
There was a problem hiding this comment.
- What happened to
opt_in_at? How do we handle this?
| $update, | ||
| // generally, this should not be used since we do not remove lists | ||
| // but sending just in case to prevent removals being marked as unsubscribes | ||
| ListRemovalReason::OTHER |
Member
There was a problem hiding this comment.
- What are the possible scenarios where removals could happen here?
Member
Author
There was a problem hiding this comment.
here, removals should not happen. ListRemovalReason::OTHER is sent as a placeholder
Member
Author
There was a problem hiding this comment.
opt_in_at is no longer used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #434
closes #319
closes #447
Changes
POST /subscribersendpoint to create or update a subscriberPATCH /subscribers/:idremovedUNSUBSCRIBEDstatus removed (columns are not yet removed, only the entities)subscribers.unsubscribed_atremovedsubscribers.opt_in_atremoved (we no longer want to restrict admins with this - status is enough)Migration command: