refactor(order): 주문 및 결제 이벤트 핸들러 리팩토링#40
Merged
Merged
Conversation
- 주문 확정 및 취소 이벤트 처리 로직 개선 - 결제 완료, 실패, 타임아웃 이벤트 처리 로직 추가 - 데이터 플랫폼 전송 로직을 명확히 하여 가독성 향상
- CouponConsumeEvent에서 CouponEntity를 Long 타입의 couponId와 userId로 변경 - 쿠폰 사용 로직에서 쿠폰 정보를 서비스 호출로 변경하여 코드 간소화
- 결제 실패 처리 메서드 통합 - 이벤트 발행 로직을 fail 메서드로 이동하여 코드 간결화 - 로그 메시지 개선으로 오류 추적 용이
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
💬 Review Points
✅ Checklist
📎 References