Skip to content

ENG-44604: Add metrics to count no. of API entities per category per tenant #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aditya-choubey2512 merged 6 commits into from
May 28, 2024
Merged

ENG-44604: Add metrics to count no. of API entities per category per tenant #285

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6093683
add metric
aditya-choubey2512 May 22, 2024
c0eec3e
Merge branch 'main' into ENG-44604
aditya-choubey2512 May 22, 2024
af5c569
minor refactor
aditya-choubey2512 May 22, 2024
b37f872
corrected attribute paths
aditya-choubey2512 May 22, 2024
1ac8101
spotlessApply
aditya-choubey2512 May 22, 2024
746f2c8
Merge branch 'main' into ENG-44604
aditya-choubey2512 May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions entity-service-impl/src/main/java/org/hypertrace/entity/metric/EntityMetricsReporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import org.hypertrace.core.documentstore.expression.impl.ConstantExpression;
import org.hypertrace.core.documentstore.expression.impl.IdentifierExpression;
import org.hypertrace.core.documentstore.expression.impl.RelationalExpression;
import org.hypertrace.core.documentstore.expression.impl.UnnestExpression;
import org.hypertrace.core.documentstore.expression.operators.RelationalOperator;
import org.hypertrace.core.documentstore.model.config.CustomMetricConfig;
import org.hypertrace.core.documentstore.query.Filter;
Expand All @@ -22,10 +23,15 @@
public class EntityMetricsReporter {

private static final String API_COUNT_METRIC_NAME = "api.entities.count";
private static final String API_CATEGORY_METRIC_NAME = "api.categories.count";
private static final String RAW_ENTITIES_COLLECTION = "raw_entities";
private static final String API_DISCOVERY_STATE_ENTITY_PATH =
"attributes.api_discovery_state.value.string";
private static final String API_CATEGORIES_ENTITY_PATH = "attributes.categories.valueList.values";
private static final String API_CATEGORY_ENTITY_PATH =
"attributes.categories.valueList.values.value.string";
private static final String API_DISCOVERY_STATE = "apiDiscoveryState";
private static final String API_CATEGORY = "category";
private static final String TENANT_ID_ENTITY_PATH = "tenantId";
private static final String ENTITY_TYPE_ENTITY_PATH = "entityType";
private final DocStoreMetricsRegistry metricsRegistry;
Expand Down Expand Up @@ -66,6 +72,31 @@ public void monitor() {
IdentifierExpression.of(API_DISCOVERY_STATE_ENTITY_PATH))
.build())
.build())
.build(),
DocStoreCustomMetricReportingConfig.builder()
.reportingInterval(Duration.ofHours(6))
.config(
CustomMetricConfig.builder()
.metricName(API_CATEGORY_METRIC_NAME)
.collectionName(RAW_ENTITIES_COLLECTION)
.query(
Query.builder()
.setFilter(getFilter())
.addFromClause(
UnnestExpression.builder()
.identifierExpression(
IdentifierExpression.of(API_CATEGORIES_ENTITY_PATH))
.build())
.addSelection(IdentifierExpression.of(TENANT_ID_ENTITY_PATH))
.addSelection(
IdentifierExpression.of(API_CATEGORY_ENTITY_PATH), API_CATEGORY)
.addSelection(
AggregateExpression.of(COUNT, ConstantExpression.of(1)),
VALUE_KEY)
.addAggregation(IdentifierExpression.of(TENANT_ID_ENTITY_PATH))
.addAggregation(IdentifierExpression.of(API_CATEGORY_ENTITY_PATH))
.build())
.build())
.build());

private Filter getFilter() {
Expand Down