Skip to content

NO-TICKET: Add getDefaultPreviousValue hook to IdentifiedObjectStore #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TriggerRao wants to merge 2 commits into
base: main
Choose a base branch
from
Open

NO-TICKET: Add getDefaultPreviousValue hook to IdentifiedObjectStore #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8306194
NO-TICKET: Add getDefaultPreviousValue hook to IdentifiedObjectStore
Tarun-Rao-Harness Jun 18, 2026
9444f5f
NO-TICKET: Add missing transitive config-service-api locks for runtim…
Tarun-Rao-Harness Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions ...g-object-store/src/main/java/org/hypertrace/config/objectstore/IdentifiedObjectStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,10 @@ protected String buildClassNameForChangeEvent(T data) {
return data.getClass().getName();
}

protected Optional<Value> getDefaultPreviousValue(RequestContext requestContext, T data) {
return Optional.empty();
}

protected List<ContextualConfigObject<T>> orderFetchedObjects(
List<ContextualConfigObject<T>> objects) {
return objects;
Expand Down Expand Up @@ -279,7 +283,7 @@ private Optional<ContextualConfigObject<T>> processUpsertResult(
if (response.hasPrevConfig()) {
tryReportUpdate(requestContext, result, response.getPrevConfig());
} else {
tryReportCreation(requestContext, result);
reportCreationOrDefaultUpdate(requestContext, result);
}
});
return optionalResult;
Expand All @@ -295,12 +299,23 @@ private Optional<ContextualConfigObject<T>> processUpsertResult(
if (upsertedConfig.hasPrevConfig()) {
tryReportUpdate(requestContext, result, upsertedConfig.getPrevConfig());
} else {
tryReportCreation(requestContext, result);
reportCreationOrDefaultUpdate(requestContext, result);
}
});
return optionalResult;
}

private void reportCreationOrDefaultUpdate(
RequestContext requestContext, ContextualConfigObject<T> result) {
Optional<Value> defaultPreviousValue =
getDefaultPreviousValue(requestContext, result.getData());
if (defaultPreviousValue.isPresent()) {
tryReportUpdate(requestContext, result, defaultPreviousValue.get());
} else {
tryReportCreation(requestContext, result);
}
}

private DeletedContextualConfigObject<T> processDeleteResult(
RequestContext requestContext, ContextSpecificConfig deletedConfig) {
DeletedContextualConfigObject<T> deletedContextualConfigObject =
Expand Down
4 changes: 4 additions & 0 deletions config-service/gradle.lockfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,10 @@ org.eclipse.jetty:jetty-util:11.0.26=integrationTestRuntimeClasspath,runtimeClas
org.hamcrest:hamcrest:2.1=integrationTestRuntimeClasspath
org.hdrhistogram:HdrHistogram:2.2.2=integrationTestRuntimeClasspath,runtimeClasspath,testRuntimeClasspath
org.hypertrace.bom:hypertrace-bom:0.3.74=compileClasspath,integrationTestCompileClasspath,integrationTestRuntimeClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
org.hypertrace.config.service:label-application-rule-config-service-api:0.1.74=integrationTestRuntimeClasspath,runtimeClasspath,testRuntimeClasspath
org.hypertrace.config.service:labels-config-service-api:0.1.74=integrationTestRuntimeClasspath,runtimeClasspath,testRuntimeClasspath
org.hypertrace.config.service:spaces-config-service-api:0.1.74=integrationTestRuntimeClasspath,runtimeClasspath,testRuntimeClasspath
org.hypertrace.config.service:span-processing-config-service-api:0.1.74=integrationTestRuntimeClasspath,runtimeClasspath,testRuntimeClasspath
org.hypertrace.core.documentstore:document-store:0.8.6=integrationTestCompileClasspath,integrationTestRuntimeClasspath,runtimeClasspath,testRuntimeClasspath
org.hypertrace.core.eventstore:event-store:0.1.5=integrationTestRuntimeClasspath,runtimeClasspath,testRuntimeClasspath
org.hypertrace.core.grpcutils:grpc-client-rx-utils:0.13.22=integrationTestRuntimeClasspath,runtimeClasspath,testRuntimeClasspath
Expand Down
Loading