fix(abi): close last Tier2 assert_total via fuel recursion + FP classifications - #56
Merged
Merged
Conversation
…ifications bufferToList now recurses structurally on a remaining-byte Nat fuel instead of asserting totality on an increasing Int index. Semantics unchanged (n <= 0 yields [], bytes read [0, n) in order); the totality checker accepts it directly, restoring the proof-corpus zero proof-escape contract that #52's merge gate promised. audits/assail-classifications.a2ml records the audited FFI residuals from a fresh panic-attack 2.5.5 scan: the documented unsafe blocks in recompute-wasm and attest (both files carry in-file UNSAFE POLICY sections and deny(clippy::undocumented_unsafe_blocks)) and the Zig C-ABI bridge cast. The assert_total finding is fixed, not classified. vcl-ut also gains scan coverage for the first time: it had NO entry in verisimdb-data/scans at all (coverage gap fixed estate-wide by hypatia's new estate-rescan workflow).
hyperpolymath
marked this pull request as ready for review
June 11, 2026 22:41
hyperpolymath
pushed a commit
that referenced
this pull request
Jun 12, 2026
…usion Follow-up to #56 (merged before these CI fixes were pushed): 1. reuse-lint: audits/assail-classifications.a2ml lacked a copyright notice — adds the standard line alongside the SPDX identifier. 2. dogfood-gate: the registry is panic-attack's S-expression user-classification dialect, not the TOML-like manifest A2ML the gate validates. Excluded via the validate action's paths-ignore (defaults restated — a custom value replaces them) and the detect-count find.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the estate loop repair (hyperpolymath/hypatia#458).
What
src/interface/abi/Tier2.idr:bufferToListrecursed on an increasingIntindex and silenced the totality checker withassert_total— the one remaining proof escape in the Tier-2 ABI, contradicting the zero-proof-escape contract from feat(abi): Tier-2 Idris bindings + retire legacy Foreign + close L10 transitive cycle #52's merge gate (and flagged ProofDrift High by panic-attack). Now it recurses structurally on a remaining-byteNatfuel (integerToNat (cast n)): semantics unchanged (n <= 0→[], bytes read[0, n)in order), and the totality checker accepts it directly. The proof-corpus CI job is the verifying gate for this change.audits/assail-classifications.a2ml: audited FFI residuals from a fresh panic-attack 2.5.5 scan — the documented unsafe blocks inrecompute-wasmandattest(both carry in-file UNSAFE POLICY sections anddeny(clippy::undocumented_unsafe_blocks); decision logic lives in theforbid(unsafe_code)vcltotal-parsecrate) and the Zig C-ABI bridge cast. Theassert_totalfinding is fixed, not classified.Context
vcl-ut had no entry at all in the canonical scan store (coverage gap) — fixed estate-wide by hypatia#458's estate-rescan workflow. Fresh scan after this change: unsuppressed non-heuristic Critical/High = 0.
https://claude.ai/code/session_01EzjC8MEx3Kzf3pdMhaQSks
Generated by Claude Code