fix(pages): 60-min timeout, drop duplicate workflow, pin action to digest - #49
Conversation
…gest Pages has NEVER deployed. https://hyperpolymath.github.io/oikosbot/ is 404 and all 30 casket-pages runs are 'cancelled'. They are not cancellations — they are timeouts: the job dies in 'Build casket-ssg' (cold GHCup/Cabal) against timeout-minutes: 15, and GitHub reports timeout expiry as 'cancelled', not 'failed'. Thirty consecutive timeouts therefore read as noise rather than a broken site. Raised to 60. Removed .github/workflows/pages.yml: a second, disabled_manually Pages workflow (Ddraig SSG) declaring the same concurrency group 'pages' as the active casket-pages.yml. Two Pages workflows in one concurrency group is a standing hazard and the disabled one deploys nothing. casket-pages.yml is the active, canonical path; recoverable via git revert if Ddraig is preferred later. Pinned the action's default image to a digest rather than :latest, per the estate SHA-pinning doctrine — a consumer's results should not change without a change on their side. Trade-off: fixes no longer propagate automatically (that is how the SARIF fix reached the pilot), so each release must bump this digest. Verified the pinned digest resolves, runs (oikosbot 0.1.0), and contains the SARIF fix. Pareto-Trade-off: reproducibility over auto-propagation. Competing objectives are supply-chain determinism vs. fix latency for consumers; chose determinism because a silently-changing analyzer undermines every verdict it issues. Metric impact: none on carbon/perf; adds one release step. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Note Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime. Code Review ✅ ApprovedIncreases the GitHub Pages build timeout to 60 minutes, removes the duplicate pages workflow, and pins the action to a specific digest. No issues found.
OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|
|
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
1 participant
Three small rulings from the maintenance review.
1. Pages has never deployed — and it looked like noise
https://hyperpolymath.github.io/oikosbot/returns 404, and all 30 casket-pages runs showcancelled. They are not cancellations: the job dies in Build casket-ssg (cold GHCup/Cabal) againsttimeout-minutes: 15, and GitHub reports timeout expiry as "cancelled", not "failed" — so thirty consecutive timeouts read as noise instead of a broken site. Raised to 60.2. Duplicate Pages workflow removed
pages.yml(Ddraig SSG) wasdisabled_manuallyyet declared the same concurrency grouppagesas the activecasket-pages.yml. Two Pages workflows in one concurrency group is a standing hazard, and the disabled one deploys nothing.casket-pages.ymlis the canonical path;git revertrestores the other if Ddraig is preferred.3. Action pinned to a digest, not
:latestPer estate SHA-pinning doctrine — a consumer's results should not change without a change on their side.
Trade-off, stated explicitly: fixes no longer propagate automatically (that is precisely how today's SARIF fix reached the pilot), so each release must bump this digest. Chose determinism because a silently-changing analyzer undermines every verdict it issues.
Verified the pinned digest resolves, runs (
oikosbot 0.1.0), and contains the SARIF fix.🤖 Generated with Claude Code