Skip to content

chore: fill or remove RSR template placeholders - #65

Merged
hyperpolymath merged 6 commits into
mainfrom
fix/rsr-placeholders
Jul 28, 2026
Merged

chore: fill or remove RSR template placeholders#65
hyperpolymath merged 6 commits into
mainfrom
fix/rsr-placeholders

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

openssf-compliance.yml fails when any of the thirteen files it checks still contains a {{PLACEHOLDER}} token. This clears them, with no invention.

  • Deleted the TEMPLATE INSTRUCTIONS (delete this block before publishing) comment — the template says to delete it, and it is where every legend line lived, so a large share of the reported tokens were the file documenting its own placeholders.
  • Filled what the repository itself supplies: owner and repo from the git remote, project name, year, forge, main branch, contact email.
  • Removed PGP and website lines. https://github.com/<user>.gpg returns HTTP 200 for every account; with no key uploaded the body is a stub reading "This user hasn't uploaded any GPG keys". No key is published for either account, and commit signing here is SSH — unrelated. The template sanctions this: "Optional: Remove sections that don't apply (e.g. PGP if you don't use it)."\n\nA security policy telling a researcher to encrypt to a key that does not exist is worse than one that does not mention encryption.\n\nWhere applicable, this also fixes a misrouted advisory URL. A previous just init copied already-filled templates out of squisher-corpus, so 51 repositories directed vulnerability reports to hyperpolymath/squisher-corpus — a repository unrelated to the code being reported, meaning the affected maintainer never saw them. Repointed from this repository's own git remote.

hyperpolymath and others added 5 commits July 26, 2026 14:44
openssf-compliance.yml fails when any of the thirteen files it checks
still contains a {{PLACEHOLDER}} token. This clears them.

Three kinds of change, no invention:

The "TEMPLATE INSTRUCTIONS (delete this block before publishing)" comment
is deleted. The template says to delete it, and it is where every legend
line lives -- so a large share of the reported tokens were the file
documenting its own placeholders, not real unfilled fields.

Tokens derivable from the repository are filled: owner and repo from the
git remote, project name, year, forge, main branch, contact email.

PGP and website lines are removed rather than filled, because nothing
true could go in them. https://github.com/<user>.gpg returns HTTP 200 for
every account; with no key uploaded the body is a stub reading "This user
hasnt uploaded any GPG keys". No key is published for either account
here, and commit signing in this estate is SSH, which is unrelated. Only
one repository in the estate has a domain, so {{WEBSITE}} likewise has no
correct value. The template sanctions this: "Optional: Remove sections
that dont apply (e.g. PGP if you dont use it)." A security policy telling
a researcher to encrypt to a key that does not exist is worse than one
that does not mention encryption.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
@gitar-bot

gitar-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

Note

Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime.
Learn more

CI failed: CI failures span a CodeQL action version resolution error, a hardcoded secret detection policy violation, a Rust compilation error due to a missing `Clone` implementation on `PluginLoader`, and a vulnerability in the `crossbeam-epoch` dependency.

Overview

Multiple distinct failures occurred across CI jobs, including a workflow configuration error for CodeQL, a custom security policy violation detecting hardcoded secrets, a Rust compilation error in the fslint-core benchmark, and a security audit vulnerability in a dependency.

Failures

CodeQL Action Resolution Error (confidence: high)

  • Type: configuration
  • Affected jobs: 90326254686
  • Related to change: yes
  • Root cause: The CodeQL action is referenced with an invalid or inaccessible commit SHA (29b1f65c1f735799893313399435a59f54045865).
  • Suggested fix: Verify and update the commit SHA or tag for github/codeql-action in .github/workflows/codeql.yml to a valid version.

Potential Hardcoded Secrets Detected (confidence: high)

  • Type: tooling
  • Affected jobs: 90326256567
  • Related to change: yes
  • Root cause: A custom security check script in CI flagged potential hardcoded secrets matching regex patterns for API keys, secret keys, or passwords.
  • Suggested fix: Review files for accidental hardcoded credentials, replace them with environment variables, or update the grep exclusion patterns if they are false positives.

Missing Clone implementation on PluginLoader (confidence: high)

  • Type: build
  • Affected jobs: 90326427982
  • Related to change: unclear
  • Root cause: crates/fslint-core/benches/scanner_benchmark.rs calls loader.clone() on PluginLoader, but PluginLoader does not implement Clone (E0599).
  • Suggested fix: Derive or implement Clone for PluginLoader, or adjust the benchmark to construct new instances instead of cloning.

Dependency Vulnerability in crossbeam-epoch (confidence: high)

  • Type: dependency
  • Affected jobs: 90326428078
  • Related to change: unclear
  • Root cause: Cargo audit found RUSTSEC-2026-0204 (crossbeam-epoch version 0.9.18 vulnerable to invalid pointer dereference).
  • Suggested fix: Update crossbeam-epoch to version >=0.9.20 via Cargo.

Summary

  • Change-related failures: 2 (CodeQL action reference and security policy secret check)
  • Infrastructure/flaky failures: 0
  • Recommended action: Fix the CodeQL workflow action SHA, inspect and remove any hardcoded secrets flagged by the security policy check, implement Clone on PluginLoader for the benchmark, and update the crossbeam-epoch dependency.
Code Review ✅ Approved 1 resolved / 1 findings

Fills RSR template placeholders and updates security workflows, but guix.scm mislabels filesoup as squisher-corpus, causing a critical identity mismatch.

✅ 1 resolved
Bug: guix.scm mislabels filesoup as squisher-corpus

📄 guix.scm:2 📄 guix.scm:10 📄 guix.scm:14 📄 guix.scm:15 📄 guix.scm:16
This is the filesoup repository (README/codemeta/Cargo.toml all identify it as file-soup/FSLint), but guix.scm now names the package "squisher-corpus", describes it as squisher-corpus, and sets home-page to github.com/hyperpolymath/squisher-corpus. The commit copied another repo's package definition unchanged. guix shell -f guix.scm will build/publish the wrong package identity. Restore name/synopsis/description/home-page to filesoup.

Tip

Comment Gitar fix CI to trigger a fix.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Comment thread guix.scm
@hyperpolymath
hyperpolymath merged commit 61a579d into main Jul 28, 2026
17 of 20 checks passed
@hyperpolymath
hyperpolymath deleted the fix/rsr-placeholders branch July 28, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant