add back minimal vscode settings file for rust-analyzer#254
Merged
ludfjig merged 1 commit intohyperlight-dev:mainfrom Feb 20, 2025
Merged
add back minimal vscode settings file for rust-analyzer#254ludfjig merged 1 commit intohyperlight-dev:mainfrom
ludfjig merged 1 commit intohyperlight-dev:mainfrom
Conversation
simongdavies
approved these changes
Feb 12, 2025
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
ludfjig
force-pushed
the
vscode_setting
branch
from
ea7f538 to
72c0948
Compare
marosset
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#66 removed .vscode/settings.json and .vscode/launch.json. After some thinking, I think we removed a bit too much in that PR.
This PR adds back a minimal settings.json, which makes rust-analyzer work with simpleguest and callbackguest. Importantly, the setting should have no impact on users not using vscode. If anyone has a strong opinion why we should NOT check-in this file, please let me know.