Fix just fmt command in rust GH job#49
Merged
dblnz merged 1 commit intohyperlight-dev:mainfrom May 16, 2025
Merged
Conversation
Merged
simongdavies
force-pushed
the
fix-fmt-in-ci
branch
from
7f7ecde to
c2c8248
Compare
Instead of checking rust fmt the pipeline job incorrectly fixes any issues Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
simongdavies
force-pushed
the
fix-fmt-in-ci
branch
from
c2c8248 to
36c0e83
Compare
dblnz
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of running
just fmt-checkthe pipeline job incorrectly runsjust fmtwhich fixes any issues, these don't get committed and pushed back to main so subsequently fetching changes and runningjust buildcan fail.This requires #47 to be merged first, status checks will fail until that PR is merged