Make sure hosts don't need hyperlight-host dependency#291
Merged
simongdavies merged 3 commits intohyperlight-dev:mainfrom Dec 8, 2025
Merged
Make sure hosts don't need hyperlight-host dependency#291simongdavies merged 3 commits intohyperlight-dev:mainfrom
simongdavies merged 3 commits intohyperlight-dev:mainfrom
Conversation
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
jsturtevant
reviewed
Dec 4, 2025
jsturtevant
reviewed
Dec 4, 2025
Co-authored-by: James Sturtevant <jsturtevant@gmail.com> Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
Co-authored-by: James Sturtevant <jsturtevant@gmail.com> Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
ludfjig
approved these changes
Dec 4, 2025
Member
|
I think the component macros also use ::hyperlight_host:: paths to access things. Perhaps it would make sense to make that path configurable and reexport a host_bindgen! that accesses via ::hyperlight_wasm:: reexports instead? (If only hygiene existed...) |
Member
Author
I am not sure if we need to do that since the references to hyperlight_host are internal to the macro? we could re-export the macro and then there would only be exernal references to hyperlight_wasm types. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving the public API of the
hyperlight_wasmcrate by re-exporting key types fromhyperlight_host. This allows consumers ofhyperlight_wasmto use its API without needing to depend directly onhyperlight_host. Additionally, minor documentation and code cleanup changes are included.Code Cleanup
get_configmethod fromSandboxBuilder, simplifying the builder's API.loaded_wasm_sandbox.rsto align with the new API structure.