Allow setting the function definition size#184
Merged
jprendes merged 1 commit intohyperlight-dev:mainfrom Sep 1, 2025
Merged
Conversation
simongdavies
requested changes
Sep 1, 2025
jprendes
force-pushed
the
set-func-def-size
branch
from
0cc2351 to
ad84678
Compare
Member
|
Can we just get rid of the host function definition region instead? The only user is module-style hyperlight-wasm as far as I know, and that can be trivially replaced by having hyperlight-wasm itself define a hostcall that returns the correct thing and doesn't require a static buffer size. |
Contributor
Author
|
I think we can do that for 0.10.0 |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
syntactically
previously approved these changes
Sep 1, 2025
Member
syntactically
left a comment
syntactically
left a comment
There was a problem hiding this comment.
OK, if this is just so that we can do a release that depends on 0.9.0 and we'll get rid of it soon, then LGTM. I made an issue for getting rid of the region altogether: hyperlight-dev/hyperlight#847.
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
jprendes
force-pushed
the
set-func-def-size
branch
from
ad84678 to
281a401
Compare
simongdavies
approved these changes
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large WIT_WORLD's can easily exceed the size of the default host function definition buffer size.
This PR adds a method to change the size of that buffer.