Feature Improvement: Add url option to open-telemetry SDK config#209
Open
pcga11 wants to merge 1 commit intohyperdxio:mainfrom
Open
Feature Improvement: Add url option to open-telemetry SDK config#209pcga11 wants to merge 1 commit intohyperdxio:mainfrom
pcga11 wants to merge 1 commit intohyperdxio:mainfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the HyperDX Node SDK reads the OTLP endpoint exclusively from environment variables (OTEL_EXPORTER_OTLP_ENDPOINT). This works well for simple setups, but becomes problematic when running multiple OTEL collectors in the same environment.
In my team's case, we use multiple OTEL collectors and need to send telemetry from HyperDX to a different endpoint than our other instrumentation. Since OTEL_EXPORTER_OTLP_ENDPOINT is already in use, and the SDK defaults to https://in-otel.hyperdx.io when not set, there's no way to programmatically override the endpoint.
Solution
So, I've added an optional endpoint config option to init() / initSDK():
Gives users explicit control over where telemetry is sent.