Skip to content

Add xb_builder_add_default_locales()#104

Open
hughsie wants to merge 1 commit into
mainfrom
wip/hughsie/xb_builder_add_default_locales
Open

Add xb_builder_add_default_locales()#104
hughsie wants to merge 1 commit into
mainfrom
wip/hughsie/xb_builder_add_default_locales

Conversation

@hughsie

@hughsie hughsie commented Nov 28, 2021

Copy link
Copy Markdown
Owner

Fixes #41

@hughsie hughsie requested a review from pwithnall November 28, 2021 10:47
@pwithnall

Copy link
Copy Markdown
Collaborator

What’s implemented here is not what was discussed in #41. Howcome?

@hughsie

hughsie commented Nov 29, 2021

Copy link
Copy Markdown
Owner Author

I don't think we can do it that way; we need the current system locales to be part of the silo invalidation GUID.

@pwithnall

Copy link
Copy Markdown
Collaborator

I don’t follow how that precludes adding a use-system-locales property and allowing it to be set to TRUE when constructing an XbBuilder.

In the xb-tool.c changes in this MR, that would mean:

  • xb_builder_new()xb_builder_new_with_system_locales() or something equivalent
  • xb_builder_constructed() would call xb_builder_add_default_locales() if use-system-locales was set to TRUE
  • Explicit call to xb_builder_add_default_locales() in xb-tool.c is no longer needed

@hughsie

hughsie commented Dec 2, 2021

Copy link
Copy Markdown
Owner Author

xb_builder_new() → xb_builder_new_with_system_locales() or something equivalent

That seems like we're painting ourselves into a corner. What about xb_builder_new_full() with some flags like XB_BUILDER_FLAG_USE_SYSTEM_LOCALES?

@pwithnall

Copy link
Copy Markdown
Collaborator

Sure, the suggestion of xb_builder_new_with_system_locales() was just to illustrate my point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XbBuilder could work without explicit xb_builder_add_locale() calls

2 participants