Add Qwen2MoE#29377
Conversation
ArthurZucker
left a comment
There was a problem hiding this comment.
Thanks a few small comments for a small review for now!
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
left a comment
There was a problem hiding this comment.
Thanks! Overall alright, I think one thing we need to be careful about is to test in the terst_modeling_qwen2_moe when there are sparse and non sparse. The loss needs to ignore None router logits!
|
Hey, I guess our update of the testing solves the issues mentioned. Take another look? |
ArthurZucker
left a comment
There was a problem hiding this comment.
LGTM Almost not comment, I'll do another full review tomorrow but it is pretty much mergable ! 🔥
Mostly using the latest api would be nice for cache_positions in the Model, but it's really optional!
Co-authored-by: Arthur <48595927+ArthurZucker@users.noreply.github.com>
|
@ArthurZucker Hi, I have rebased our branch and solved all the conflicts. I think the codes are ready to be merged now. |
|
Thanks for your efforts! merging 🥳 |
|
Hi @bozheng-hit Thank you for adding this model 🚀 I see https://huggingface.co/models?search=Qwen1.5-MoE Could you check this, open a PR to make some necessary updates, and make sure the integration tests pass by running
Thank you in advance |
|
Didn't saw |
Adding Qwen2MoE
This PR adds the support of codes for the coming Qwen2MoE models. For information about Qwen, please visit https://github.com/QwenLM/Qwen. @ArthurZucker