Implemented createFrom stream command and fixed bug with create permissions#34
Open
ddold wants to merge 1 commit intohubert-marteau:masterfrom
ddold:some_changes
Open
Implemented createFrom stream command and fixed bug with create permissions#34ddold wants to merge 1 commit intohubert-marteau:masterfrom ddold:some_changes
ddold wants to merge 1 commit intohubert-marteau:masterfrom
ddold:some_changes
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented the createFrom method as I needed to use it. I followed the same style and format of your code.
I also noticed a bug when implementing the create permission. If the create byte value is set, it still does not enter the if statement. So instead of checking if its greater than 0, I reverse the check and see if its less than 0. I tested this when adding multiple permissions and just the create permission on its own and verify it works.