fix(to_cpp1): support initializing assignment from expression list in operator=#680
Closed
JohelEGP wants to merge 1 commit intohsutter:mainfrom
Closed
fix(to_cpp1): support initializing assignment from expression list in operator=#680JohelEGP wants to merge 1 commit intohsutter:mainfrom
operator=#680JohelEGP wants to merge 1 commit intohsutter:mainfrom
Conversation
JohelEGP
force-pushed
the
assign_expression_list
branch
from
9ace4d9 to
8c76ae9
Compare
JohelEGP
changed the title
operator=operator=
JohelEGP
force-pushed
the
assign_expression_list
branch
from
8c76ae9 to
eb7cd63
Compare
Owner
|
Hi! Sorry it took me so long to get to this one... but this is really tactical and looks like it might still be current, modulo the conflict. Is this up to date (after resolving the merge conflict), and would you like me to review it? |
hsutter
added
the
question - further information requested
JohelEGP
force-pushed
the
assign_expression_list
branch
from
eb7cd63 to
8324e25
Compare
Contributor
Author
|
Yes, and yes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #679.
Testing summary:
Acknowledgements: