Skip to content

[feat[ Support one-behind to reduce bubble time. Add profiling code#6353

Merged
TongLi3701 merged 9 commits intogrpo-latestfrom
grpo_optimization
Jun 30, 2025
Merged

[feat[ Support one-behind to reduce bubble time. Add profiling code#6353
TongLi3701 merged 9 commits intogrpo-latestfrom
grpo_optimization

Conversation

@YeAnbang
Copy link
Copy Markdown
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs
  • I have installed pre-commit: pip install pre-commit && pre-commit install

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@YeAnbang YeAnbang requested a review from a team as a code owner June 20, 2025 07:53
@YeAnbang YeAnbang changed the title [feat[ Support one-behind to reduce bubble time [feat[ Support one-behind to reduce bubble time. Add profiling code Jun 20, 2025
@TongLi3701 TongLi3701 merged commit b1f646c into grpo-latest Jun 30, 2025
3 checks passed
YeAnbang added a commit that referenced this pull request Aug 5, 2025
…6353)

* support n_behind, add profiling

* fix bugs

* fix visualization

* fix behind

* fix loop issue

* add profiling

* fix update

* update assert

* remove assert

---------

Co-authored-by: Tong Li <tong.li35271158@gmail.com>
YeAnbang added a commit that referenced this pull request Aug 5, 2025
…6353)

* support n_behind, add profiling

* fix bugs

* fix visualization

* fix behind

* fix loop issue

* add profiling

* fix update

* update assert

* remove assert

---------

Co-authored-by: Tong Li <tong.li35271158@gmail.com>
YeAnbang added a commit that referenced this pull request Aug 5, 2025
…6353)

* support n_behind, add profiling

* fix bugs

* fix visualization

* fix behind

* fix loop issue

* add profiling

* fix update

* update assert

* remove assert

---------

Co-authored-by: Tong Li <tong.li35271158@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants