fix: pass full tar path to verify-packed-manifests#626
Open
hobostay wants to merge 1 commit intoheygen-com:mainfrom
Open
fix: pass full tar path to verify-packed-manifests#626hobostay wants to merge 1 commit intoheygen-com:mainfrom
hobostay wants to merge 1 commit intoheygen-com:mainfrom
Conversation
pnpm pack writes the tarball to packDir (a temp directory), but tar was invoked with cwd:ROOT and only the bare filename. Since the tarball doesn't exist at <ROOT>/<filename>, the verification always fails with "file not found". Use join(packDir, filename) so tar can find the packed tarball. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
jrusso1020
approved these changes
May 5, 2026
Collaborator
jrusso1020
left a comment
jrusso1020
left a comment
There was a problem hiding this comment.
Verified — pnpm pack --pack-destination packDir writes to the tempdir, but tar -xOf <filename> runs with cwd: ROOT, so the lookup misses unless a tarball with the same name happens to exist at repo root. Joining packDir onto the filename is the fix. The script is currently broken in CI's bun run verify:packed-manifests path; this should unblock it. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verify-packed-manifests.mjsscript that always fails becausetarcannot find the packed tarballpnpm packwrites topackDir(temp directory) buttarwas invoked with only the bare filename relative to the repo rootDetails
Affected file:
scripts/verify-packed-manifests.mjs(line 56)The script packs packages into a temp directory (
packDir), then tries to extractpackage.jsonfrom the tarball. Buttar -xOfwas given just the filename (e.g.,hyperframes-core-0.1.0.tgz) withcwd: ROOT, so it looks for the file at the repo root instead of inpackDir.Test plan
bun run verify:packed-manifestsand verify it completes successfully🤖 Generated with Claude Code