fix(security): add path traversal protection to render file serving#621
Open
hobostay wants to merge 1 commit intoheygen-com:mainfrom
Open
fix(security): add path traversal protection to render file serving#621hobostay wants to merge 1 commit intoheygen-com:mainfrom
hobostay wants to merge 1 commit intoheygen-com:mainfrom
Conversation
The /projects/:id/renders/file/* endpoint served files by joining rendersDir with the URL filename without validating the resolved path stays within rendersDir. A request to /renders/file/../../etc/passwd would serve arbitrary files. Add a ".." check on the filename and verify the resolved path starts with the renders directory. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
jrusso1020
approved these changes
May 5, 2026
Collaborator
jrusso1020
left a comment
jrusso1020
left a comment
There was a problem hiding this comment.
Verified — render.ts:186 currently does join(rendersDir, filename) with zero containment check, and existsSync will happily resolve ../../etc/passwd. The two-layer defense (literal .. rejection + startsWith(resolve(rendersDir)) containment) closes it. Worth noting this matches the pattern used in files.ts (isSafePath) — consider extracting to a shared helper in a follow-up, but not blocking. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/projects/:id/renders/file/*endpointrendersDirwithout validation, allowing../../sequences to serve arbitrary filesDetails
Affected file:
packages/core/src/studio-api/routes/render.ts(lines 180-187)A request to
/projects/1/renders/file/../../etc/passwdwould resolve to a file outside the renders directory.Test plan
..are rejected with 403🤖 Generated with Claude Code