remove dependencies to rust feature "naked functions"#95
Merged
stlankes merged 4 commits intohermit-os:masterfrom Aug 30, 2020
RWTH-OS:global_asm
Merged
remove dependencies to rust feature "naked functions"#95stlankes merged 4 commits intohermit-os:masterfrom RWTH-OS:global_asm
stlankes merged 4 commits intohermit-os:masterfrom
RWTH-OS:global_asm
Conversation
Contributor
stlankes
commented
Aug 30, 2020
stlankes
commented
- naked functions does currently not work (nightly: segfault with asm!() / #[naked] (possible LLVM 11 bug) rust-lang/rust#75922)
- we replaced naked functions by assembly code
- using global_asm to include the assembly code
- naked functions does currently not work (rust-lang/rust#75922) - we replaced naked functions by assembly code - using global_asm to include the assembly code
- only necessary in test environments
Contributor
Author
|
This PR should solve issue #94 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.