Work not only in the public schema#76
Merged
lucasmdrs merged 5 commits intohellofresh:masterfrom Sep 15, 2022
vgarvardt:fix/non-public-schema
Merged
Work not only in the public schema#76lucasmdrs merged 5 commits intohellofresh:masterfrom vgarvardt:fix/non-public-schema
lucasmdrs merged 5 commits intohellofresh:masterfrom
vgarvardt:fix/non-public-schema
Conversation
Contributor
|
@vgarvardt please update with master when you have the time 🙏 |
Contributor
Author
|
@lucasmdrs rebased |
Contributor
|
the tests seem to be a bit flaky, I'll take a look at that later 🙁 |
Contributor
Author
|
It seems that unit test is failing due to some hardcoded timing condition. |
Contributor
Author
|
Tried to reproduce the problem locally, but all the 50 runs I did were successful. |
Contributor
|
I managed to reproduce the case locally, decided to fix by changing the way the assertions are being made |
Contributor
Author
|
Cool, thank you! Will rebase my branch after #78 is merged. |
Contributor
Author
|
rebased |
lucasmdrs
approved these changes
Sep 15, 2022
Contributor
Author
|
@lucasmdrs can you pls release new version with the fixed and updates lately merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
publicschema is hardcoded that prevents some functionality from working correctly when non-publis schema is being used.