[IMP] bus_record_events: optimize mixin notification performance#2
Merged
zamberjo merged 2 commits intoMay 18, 2026
Merged
Conversation
zamberjo
commented
May 11, 2026
zamberjo
commented
Collaborator
- Batch create notifications: emit one bus.bus row per batch with data.ids instead of one per record (O(N) → O(1))
- Batch Many2one display_name resolution: prefetch all M2O values grouped by comodel to avoid N+1 queries (_prefetch_m2o_display_names)
- Prefetch display_name for the whole recordset before the per-record loop using records.mapped("display_name")
- Build notification dicts directly instead of copy()+mutate
- Update tests to match new create payload shape (data.id → data.ids)
- Batch create notifications: emit one bus.bus row per batch with
data.ids instead of one per record (O(N) → O(1))
- Batch Many2one display_name resolution: prefetch all M2O values
grouped by comodel to avoid N+1 queries (_prefetch_m2o_display_names)
- Prefetch display_name for the whole recordset before the per-record
loop using records.mapped("display_name")
- Build notification dicts directly instead of copy()+mutate
- Update tests to match new create payload shape (data.id → data.ids)
maurochip
approved these changes
May 14, 2026
sersanchus
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.