Skip to content

bindir-method, copy-bindir, new-install flags in SavedConfig -- 2.4 version#5869

Merged
fgaz merged 3 commits into
haskell:2.4from
fgaz:new-install/bindir-method-2.4
Mar 13, 2019
Merged

bindir-method, copy-bindir, new-install flags in SavedConfig -- 2.4 version#5869
fgaz merged 3 commits into
haskell:2.4from
fgaz:new-install/bindir-method-2.4

Conversation

@fgaz
Copy link
Copy Markdown
Member

@fgaz fgaz commented Feb 3, 2019

Backport of #5870

TODOs:

  • changelog
  • docs
  • windows testing. does appveyor test new-install?
  • is the copy-bindir flag name ok? (it's only for 2.4 anyway)
  • Is it ok to rename NewFlags to ClientFlags? *ExFlags (like it's done for configure) is not very descriptive
  • bindir-method/install-method

/cc @hvr

@fgaz fgaz added priority: high 🔥 cabal-install: v2-build system Affecting v2-build and related commands that use v2-architecture (aka "nix local builds"). labels Feb 3, 2019
@fgaz fgaz added this to the 2.4.2.0 milestone Feb 3, 2019
@fgaz fgaz requested a review from hvr February 3, 2019 11:20
@fgaz fgaz force-pushed the new-install/bindir-method-2.4 branch 5 times, most recently from 2f238a4 to 505af63 Compare February 3, 2019 16:48
@fgaz
Copy link
Copy Markdown
Member Author

fgaz commented Feb 3, 2019

What about renaming bindir-method to install-method? In the 3.0 version there's no *-bindir, and I think it's better to at least keep the method flag the same

@fgaz fgaz force-pushed the new-install/bindir-method-2.4 branch from 4628e21 to b2aadb8 Compare February 4, 2019 22:38
@fgaz fgaz force-pushed the new-install/bindir-method-2.4 branch from 6291c20 to 2879217 Compare March 9, 2019 17:43
@fgaz fgaz force-pushed the new-install/bindir-method-2.4 branch 2 times, most recently from 9f11c99 to c87ef6f Compare March 12, 2019 14:12
fgaz added 2 commits March 12, 2019 15:12
Add an --install-method=symlink|copy flag which specifies how to perform
the installation.

* --copy-bindir acts on the copy install method like --symlink-bindir
  does with the symlink one
* --install-method=copy is useful in Windows where symlinking is not
supported

All new-install flags can now be configured in ~/.cabal/config

* NewInstallFlags changed to ClientInstallFlags (more descriptive than
InstallExFlags (like ConfigExFlags))
* ClientInstallFlags is now part of SavedConfig
@fgaz fgaz force-pushed the new-install/bindir-method-2.4 branch 2 times, most recently from 7ad8d7f to ac32503 Compare March 12, 2019 15:27
some platforms need an extension for executables.

Fixed how we get the bindir too.
@fgaz fgaz force-pushed the new-install/bindir-method-2.4 branch from ac32503 to 90d239e Compare March 13, 2019 10:09
@fgaz fgaz merged commit 0c1cd9c into haskell:2.4 Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cabal-install: v2-build system Affecting v2-build and related commands that use v2-architecture (aka "nix local builds"). priority: high 🔥

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant