Adapt to changes in TypeRep complete patterns#186
Merged
bgamari merged 1 commit intohaskell:masterfrom Mar 30, 2022
Merged
Conversation
5052209 to
d0e9641
Compare
GHC merge request !963 improved warnings in the presence of COMPLETE annotations. This allows the removal of the Fun pattern from the complete set. This patch accounts for the resulting changes in pattern match warnings.
d0e9641 to
48477ba
Compare
Contributor
Author
|
I believe this is ready to be merged. Companion GHC MR: !6372. |
This was referenced Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GHC merge request !963 improved the behaviour of the pattern match checker in the presence of COMPLETE annotations. This allows the removal of the
Funpattern from the complete setsCon, AppandCon', AppinData.Typeable.Internal, which I expect to be done inGHC 9.4(sobase 4.17).As a result, we get a pattern match warning in
Data.Binary.Class.putTypeRep, which this patch addresses.To be clear, the pattern was already redundant, it's just that GHC didn't see it because of how the
COMPLETEpragmas used to be set up; callingputTypeRep (Fun arg res)already went through through theAppbranch:Which indicates the
Appbranch, and not theFunbranch (which uses the tag3).