Skip to content

Docker build include git commit if possible#803

Closed
s3inlc wants to merge 2 commits intomasterfrom
docker-build
Closed

Docker build include git commit if possible#803
s3inlc wants to merge 2 commits intomasterfrom
docker-build

Conversation

@s3inlc
Copy link
Copy Markdown
Member

@s3inlc s3inlc commented Aug 12, 2022

When building a docker image for Hashtopolis, there will be an issue when the image later is updated and the container restarted. In such a case Hashtopolis is not able to figure out, that it was updated, as the build information remains set to repository.

In order to allow building docker containers which can later be updated and Hashtopolis being able to apply upgrades, it must include the git commit hash somewhere. This can be achieved by running ./build.sh which will place the hash into a file which is then included in the docker build process.

@s3inlc s3inlc requested a review from zyronix August 12, 2022 08:03
@zyronix zyronix added the enhancement Enhancement of existing features / Small addition label Sep 21, 2022
@s3inlc
Copy link
Copy Markdown
Member Author

s3inlc commented Mar 15, 2023

This PR is becoming obsolete with #866.

@s3inlc s3inlc closed this Mar 15, 2023
@s3inlc s3inlc deleted the docker-build branch March 15, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement of existing features / Small addition

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants