Migrate project to Jetpack Compose#27
Merged
haroldadmin merged 9 commits intomasterfrom Nov 28, 2021
Merged
Conversation
msfjarvis
reviewed
Nov 27, 2021
Contributor
msfjarvis
left a comment
msfjarvis
left a comment
There was a problem hiding this comment.
LGTM, great work! I've left some minor cleanup related comments but none are a blocker.
| import androidx.compose.ui.text.style.TextAlign | ||
|
|
||
| @Composable | ||
| internal fun OutlinedIconButton( |
Contributor
There was a problem hiding this comment.
The file name is IconOutlinedButton, you should probably rename it to match the function.
…mposables, use version references in build.gradle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates WhatTheStack to use Jetpack Compose, Android's new declarative UI toolkit.
I've maintained feature parity with the existing stable version of the library, but will
release this as a new major release after it's been tested through a few pre-release builds.